Bug 259735

Summary: net/turnserver: Fails to build with libressl 3.6+
Product: Ports & Packages Reporter: Ivan Rozhuk <rozhuk.im>
Component: Individual Port(s)Assignee: Muhammad Moinur Rahman <bofh>
Status: Closed FIXED    
Severity: Affects Some People CC: bofh, portmaster, rozhuk.im
Priority: --- Flags: portmaster: maintainer-feedback+
Version: Latest   
Hardware: Any   
OS: Any   
URL: https://github.com/coturn/coturn/pull/1198
Attachments:
Description Flags
patch
none
patch
none
patch
none
patch
none
patch rozhuk.im: maintainer-approval?

Description Ivan Rozhuk 2021-11-09 12:31:13 UTC
--- bin/turnserver ---
src/apps/relay/ns_ioalib_engine_impl.c:1837:5: error: incomplete definition of type 'struct ssl_st'
        ssl->rbio = rbio;
        ~~~^
/usr/local/include/openssl/ossl_typ.h:160:16: note: forward declaration of 'struct ssl_st'
typedef struct ssl_st SSL;
               ^
src/apps/relay/ns_ioalib_engine_impl.c:1932:5: error: incomplete definition of type 'struct ssl_st'
        ssl->rbio = NULL;
        ~~~^
/usr/local/include/openssl/ossl_typ.h:160:16: note: forward declaration of 'struct ssl_st'
typedef struct ssl_st SSL;
               ^
2 errors generated.
Comment 1 Ivan Rozhuk 2021-11-09 17:58:09 UTC
Created attachment 229383 [details]
patch
Comment 2 Ivan Rozhuk 2021-11-09 21:37:38 UTC
Created attachment 229395 [details]
patch

https://github.com/coturn/coturn/pull/849
Comment 3 Ivan Rozhuk 2022-09-26 03:01:53 UTC
Created attachment 236828 [details]
patch

one more patch for latest libressl
Comment 4 Rene Ladan freebsd_committer freebsd_triage 2022-11-07 14:46:45 UTC
Maintainer reset.
Comment 5 Ivan Rozhuk 2022-12-13 01:19:26 UTC
Created attachment 238743 [details]
patch

2 patch files to one file
Comment 6 Ivan Rozhuk 2023-03-19 11:05:37 UTC
Can some on handle it?
Comment 7 Ivan Rozhuk 2023-05-03 15:42:41 UTC
Created attachment 241956 [details]
patch
Comment 8 Chris Hutchinson 2023-05-03 16:48:32 UTC
Comment on attachment 241956 [details]
patch

LGTM -- thanks!
Comment 9 Chris Hutchinson 2023-05-03 16:50:01 UTC
Approved.
Sorry for the delay. Lifes' been a bit overwhelming lately.
Comment 10 commit-hook freebsd_committer freebsd_triage 2023-07-16 11:25:55 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=8635e9d8030f2c1377535e4ea0b3fe2dfc3f370f

commit 8635e9d8030f2c1377535e4ea0b3fe2dfc3f370f
Author:     Rozhuk Ivan <rozhuk.im@gmail.com>
AuthorDate: 2023-07-15 19:38:56 +0000
Commit:     Muhammad Moinur Rahman <bofh@FreeBSD.org>
CommitDate: 2023-07-16 11:24:42 +0000

    net/turnserver: Fix build with libressl

    - Pet portclippy while I am here

    PR:             259735
    Approved by:    portmaster@bsdforge.com (maintainer)

 net/turnserver/Makefile | 38 ++++++++++++++++++++++----------------
 net/turnserver/distinfo |  4 +++-
 2 files changed, 25 insertions(+), 17 deletions(-)