Bug 259737
| Summary: | security/botan2: add missing dependency on sphinx | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Dmitry Marakasov <amdmi3> | ||||||||
| Component: | Individual Port(s) | Assignee: | Dmitry Marakasov <amdmi3> | ||||||||
| Status: | Closed FIXED | ||||||||||
| Severity: | Affects Only Me | CC: | tremere | ||||||||
| Priority: | --- | Flags: | tremere:
maintainer-feedback+
|
||||||||
| Version: | Latest | ||||||||||
| Hardware: | Any | ||||||||||
| OS: | Any | ||||||||||
| Attachments: |
|
||||||||||
Created attachment 229398 [details]
Add a MANPAGES option to make building the manpage optional
Thanks for the patch.
I added MANPAGES option so you can make building the manpage optional. Also reordered some stuff to make portclippy/portfmt happy.
(In reply to Ralf van der Enden from comment #1) This is not quite correct as disabling manpages does not prevent them from being built when sphinx is present, so it doesn't fix the hidden dependency (this actually started with investigation of build failure with newer python which is not supported by sphinx). Probably it can be fixed by passing --with(out)-sphinx to configure depending on option. Created attachment 229441 [details]
Add a MANPAGES option to make building the manpage optional (pass --without-sfinx when disabled)
You're right. I always build everything using poudriere, so it won't pull in py-sfinx and disabling the MANPAGES knob always does what it's supposed to.
With the new patch I'm passing --without-sfinx when the MANPAGES option is disabled and this has the desired effect.
I'm passing it correct in the Makefile. I mistyped sphinx in my comment. Any chance of getting this committed ? Or does it still not meet the requirements? A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=fee3247210edf039b7bd0ec0f73a03417bcbd6eb commit fee3247210edf039b7bd0ec0f73a03417bcbd6eb Author: Dmitry Marakasov <amdmi3@FreeBSD.org> AuthorDate: 2021-12-03 11:37:01 +0000 Commit: Dmitry Marakasov <amdmi3@FreeBSD.org> CommitDate: 2021-12-03 11:39:03 +0000 security/botan2: add manpages support Fix hidden dependency on sphinx and introduce optional manpages support. PR: 259737 Reported by: amdmi3 Submitted by: tremere@cainites.net (maintainer) security/botan2/Makefile | 8 ++++++-- security/botan2/pkg-plist | 1 + 2 files changed, 7 insertions(+), 2 deletions(-) The new patch is good, sorry for delay. Committed, thanks! |
Created attachment 229381 [details] Patch Add missing dependency on sphinx, which is used when it's present to generate a manpage. Add named manpage to plist.