Summary: | net/vether-kmod: update to g20211111 | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | henning.matyschok | ||||||||||
Component: | Individual Port(s) | Assignee: | freebsd-ports-bugs (Nobody) <ports-bugs> | ||||||||||
Status: | Closed FIXED | ||||||||||||
Severity: | Affects Some People | CC: | fernape, portmgr | ||||||||||
Priority: | --- | Keywords: | needs-qa | ||||||||||
Version: | Latest | ||||||||||||
Hardware: | Any | ||||||||||||
OS: | Any | ||||||||||||
URL: | https://github.com/hmatyschok/if_vether/commits/master | ||||||||||||
Attachments: |
|
Description
henning.matyschok
2021-11-11 14:10:19 UTC
Typo: Created attachment 229429 [details] Diff contains changes in Makefile and distversion. Therefore, (a) softintr. over netisr(4)-component, reason: sync.'ed tx. of frames by if_bridge(4) (b) and subr. for rand. lla implemented, reason: https://svnweb.freebsd.org/base/releng/12.3/sys/net/if_ethersubr.c?revision=370953&view=markup#l1390 Henning Andersen Matyschok, 120179M11214, USAF ^Triage: [tags] in issue Titles are deprecated. ^Triage: If there is a changelog or release notes URL available for this version, please add it to the URL field. ^Triage: Please set the maintainer-approval attachment flag (to +) on patches for ports you maintain to signify approval. -- Attachment -> Details -> maintainer-approval [+] Q/A: patch did not apply cleanly. Would you mind checking it? # $FreeBSD$ ---> This tag is not in the port Makefile anymore and the patch command fails. Thanks! Created attachment 229442 [details]
Diff. contains recent changes.
Would you please commit those changes?
Henning Andersen Matyschok, 120179M11214, USAF
(In reply to Henning Matyschok from comment #3) Hi Henning, Your patch still contains references to $FreeBSD$ at the top of the file. Could you update completely? Cheers. (In reply to Fernando Apesteguía from comment #4) There ist no need for change - reason: the same reference to $FreeBSD$ was accepted at version g20190422. Henning Andersen Matyschok, 120179M11214, USAF (In reply to Henning Matyschok from comment #5) That line *is not* in the current version of the Makefile in the repository: https://cgit.freebsd.org/ports/tree/net/vether-kmod/Makefile *PLEASE* update your repo and send a new patch :-) (In reply to Fernando Apesteguía from comment #6) It is not about contents of those Makefile, this code-section remains in if_vether.c, see code-base from preceeding version g20190422, "hmatyschok-if_vether-g20190422-ecc91f865218f2bb85521b285c8f7f81198aa553_GH0.tar.gz", for further details. Therefore, there is no reason for reject version g20211111 about commited up-stream. Henning Andersen Matyschok, 120179M11214, USAF (In reply to Henning Matyschok from comment #7) I'm sorry Henning, but I don't understand what you are talking about. I'm talking about net/vether-kmod/Makefile. The patch you provided can not be applied cleanly because the context of the patch is different from the file. And it is different because of the $FreeBSD$ line. Also, I don't know what you are referring about committing upstream, sorry. Created attachment 229554 [details]
Update to g2021117
Mr. Apesteguía, therefore, a new patch was created. Henning Andersen Matyschok, 120179M11214, USAF (In reply to Henning Matyschok from comment #10) Henning, Are you using subversion for ports development? (In reply to Fernando Apesteguía from comment #11) Mr. Apesteguía, > Henning, so, it is not allowed calling individuals by ist first name without permission? > Are you using subversion for ports development? Git was not utilized accessing the ports tree. Henning Andersen Matyschok, 120179M11214, USAF (In reply to Henning Matyschok from comment #12) Typo: Mr. Apesteguía, > Henning, so, it is not allowed calling individuals by its first name without permission? > Are you using subversion for ports development? Git was not utilized accessing the ports tree. Henning Andersen Matyschok, 120179M11214, USAF (In reply to Henning Matyschok from comment #13) You can call me Fernando, Mr. Apesteguia or whatever you like, no problem there :-) > Git was not utilized accessing the ports tree. The Project moved to git long ago. You are using a *very outdated* repository version. One that is frozen in time. Please, update your patch using the *latest version of the git repository* https://docs.freebsd.org/en/books/porters-handbook/upgrading/#git-diff Cheers Created attachment 229591 [details]
Recent version, update to g20211119
Mr. Apesteguía,
therefore, the attachment contains an update to version g20211119.
Henning Andersen Matyschok, 120179M11214, USAF
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=ac92fc2bed5970f34080d38fa0069a45937e5c5b commit ac92fc2bed5970f34080d38fa0069a45937e5c5b Author: Henning Matyschok <henning.matyschok@outlook.com> AuthorDate: 2021-11-19 12:42:33 +0000 Commit: Fernando Apesteguía <fernape@FreeBSD.org> CommitDate: 2021-11-19 13:05:52 +0000 net/vether-kmod: update to g20211111 ChangeLog: https://github.com/hmatyschok/if_vether/commits/master PR: 259779 Reported by: henning.matyschok@outlook.com (maintainer) net/vether-kmod/Makefile | 7 ++++--- net/vether-kmod/distinfo | 6 +++--- 2 files changed, 7 insertions(+), 6 deletions(-) Committed, Thanks! |