Bug 259831

Summary: [NEW PORT] security/py-vpn-slice: Customized VPN split-tunnel
Product: Ports & Packages Reporter: Jose G. Juanino <jjuanino>
Component: Individual Port(s)Assignee: Dries Michiels <driesm>
Status: Closed FIXED    
Severity: Affects Only Me CC: driesm
Priority: --- Flags: jjuanino: maintainer-feedback+
Version: Latest   
Hardware: Any   
OS: Any   
URL: https://github.com/dlenski/vpn-slice
Attachments:
Description Flags
py-vpn-slice port
none
pkg-message added
jjuanino: maintainer-approval+
pkg-message format
jjuanino: maintainer-approval+
use CHEESESHOP, clean pkg-descr jjuanino: maintainer-approval+

Description Jose G. Juanino 2021-11-14 18:33:48 UTC 
Created attachment 229489 [details]
py-vpn-slice port

Hi FreeBSD team ports,

I submit a new patch to manage split tunnel in a different way than sysutils/vpnc-scripts (and IMHO, in a better way). It allows to customize the split-tunnel routers an a elegant and concise way. Example with openconnect:

openconnect \
--user ${user} \
--script 'vpn-slice 10.6.0.0/16 10.7.0.0/16 10.8.0.0/16' \
vpn.host.site

To accomplish the same with vpnc-script you have to build a long and obscure shell script as discussed in https://blog.scottlowe.org/2019/03/12/split-tunneling-with-vpnc/


Regards
Comment 1 Jose G. Juanino 2021-11-14 18:59:05 UTC 
Created attachment 229490 [details]
pkg-message added

Submit a pkg-message to indicates that procfs must be mounted.
Comment 2 Jose G. Juanino 2021-11-20 18:03:27 UTC 
Created attachment 229619 [details]
pkg-message format

pkg-message format
Comment 3 Dries Michiels freebsd_committer freebsd_triage 2021-11-21 14:30:04 UTC 
Take.
Comment 4 Dries Michiels freebsd_committer freebsd_triage 2021-11-21 14:35:23 UTC 
Thanks for the patch! After reading the patch some minor remarks (check https://wiki.freebsd.org/Python/PortsPolicy)

- It seems the package is registered on pypi, so we should use CHEESESHOP over github to fetch the sources (see MASTER_SITES on the wiki)

- You can drop the [excerpt from ..] in pkg-descr

- You will need to make an entry under security/Makefile for the new port (I can also take care of this if its not in the last version)

Rest looks good, looking forward the these last changes!
Comment 5 Jose G. Juanino 2021-11-21 16:17:22 UTC 
Created attachment 229640 [details]
use CHEESESHOP, clean pkg-descr
Comment 6 Jose G. Juanino 2021-11-21 16:20:45 UTC 
(In reply to Dries Michiels from comment #4)

Hi Dries, I have submitted a new patch following your suggestions. Thanks you for your work! Regards
Comment 7 Dries Michiels freebsd_committer freebsd_triage 2021-11-21 19:55:12 UTC 
Hi! Would you be open to filling in your full name under "preferences => account information"? This way we can give authorship to the commit as such "name <email>" in the commit log. If not I'll do it as "jjuanini <jjuanini@gmail.com>"
Comment 8 Jose G. Juanino 2021-11-22 07:49:20 UTC 
(In reply to Dries Michiels from comment #7)

Thanks, I have filled that information.

Jose G. Juanino <jjuanino@gmail.com>

Regards
Comment 9 commit-hook freebsd_committer freebsd_triage 2021-11-23 07:57:46 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=c6090ff97a4e1f49bff701a921f485f4d7a951c8

commit c6090ff97a4e1f49bff701a921f485f4d7a951c8
Author:     Jose G. Juanino <jjuanino@gmail.com>
AuthorDate: 2021-11-21 17:37:19 +0000
Commit:     Dries Michiels <driesm@FreeBSD.org>
CommitDate: 2021-11-23 06:54:02 +0000

    security/py-vpn-slice: New port

    Customized VPN split-tunnel. vpnc-script replacement for easy and
    secure split-tunnel VPN setup.

    PR:                     259831
    Approved by:            philip (mentor)
    Differential Revision:  https://reviews.freebsd.org/D33074

 security/Makefile                       |  1 +
 security/py-vpn-slice/Makefile (new)    | 18 ++++++++++++++++++
 security/py-vpn-slice/distinfo (new)    |  3 +++
 security/py-vpn-slice/pkg-descr (new)   |  9 +++++++++
 security/py-vpn-slice/pkg-message (new) | 10 ++++++++++
 5 files changed, 41 insertions(+)
Comment 10 Dries Michiels freebsd_committer freebsd_triage 2021-11-23 07:58:02 UTC 
Committed, thanks!