Bug 259992
| Summary: | Mk/Scripts/qa.sh: Bogus 'xx doesn't have a SONAME' messages are printed by stage-qa for some shared libraries | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Yuri Victorovich <yuri> | ||||
| Component: | Ports Framework | Assignee: | Yuri Victorovich <yuri> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Some People | CC: | ports-bugs, tcberner | ||||
| Priority: | --- | ||||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
*** Bug 265096 has been marked as a duplicate of this bug. *** Moin moin Looks identical to what Fedora suggested here: htps://bugzilla.redhat.com/show_bug.ci?id=1589997#c2 So, ship it. mfg Tobias Committed, thanks! A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=6af95e9e48b065580cbac3f329e73c2b83e7f02d commit 6af95e9e48b065580cbac3f329e73c2b83e7f02d Author: Yuri Victorovich <yuri@FreeBSD.org> AuthorDate: 2022-07-09 14:50:47 +0000 Commit: Yuri Victorovich <yuri@FreeBSD.org> CommitDate: 2022-07-09 14:52:33 +0000 Mk/Scripts/qa.sh: Bogus 'xx doesn't have a SONAME' messages are printed by stage-qa for some shared libraries Reason: 'grep -q SONAME' ends before it drains the pipe, pipe fails when the remaining output is too long, and 'set -o pipefail' causes the whole command to fail when it is supposed to succeed. Remedy: Please apply the attached patch fix-SONAME.patch, or alternatively remove 'set -o pipefail' from qa.sh PR: 259992 Approved by: tcberner@ (as portmgr) Mk/Scripts/qa.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) |
Created attachment 229664 [details] fix-SONAME.patch Currently stage-qa prints bogus messages 'xx doesn't have a SONAME' when readelf produces too long output. Testcase: math/vtk9 All shared libraries instaled by math/vtk9 do have SONAME but the bogus messages about missing SONAME are printed. Reason: 'grep -q SONAME' ends before it drains the pipe, pipe fails when the remaining output is too long, and 'set -o pipefail' causes the whole command to fail when it is supposed to succeed. Remedy: Please apply the attached patch fix-SONAME.patch, or alternatively remove 'set -o pipefail' from qa.sh