Summary: | [REVIVE] lang/julia: | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Eric Reardon <rizor.reardon> | ||||||
Component: | Individual Port(s) | Assignee: | freebsd-ports-bugs (Nobody) <ports-bugs> | ||||||
Status: | Closed FIXED | ||||||||
Severity: | Affects Only Me | CC: | mikael, rizor.reardon, wen, ygy | ||||||
Priority: | --- | Keywords: | feature, needs-patch, needs-qa | ||||||
Version: | Latest | Flags: | koobs:
maintainer-feedback?
(rizor.reardon) |
||||||
Hardware: | Any | ||||||||
OS: | Any | ||||||||
URL: | https://github.com/JuliaLang/julia/releases/tag/v1.7.0-rc3 | ||||||||
Attachments: |
|
Thank you Eric. Can you in addition to the full patch already included, produce and attach a diff against the last git version of lang/julia10 so we can review the delta. If you can confirm the port passes QA as well (portlint, poudriere at least), that'd also be great. #freebsd-ports on Libera.Chat IRC if you need help/support getting that running Aaaand, I missed that QA had been confirmed, cancel last request (modulo the delta diff), apologies :) lang/julia10 was deleted back in the svn port days, is there a way to make a git diff. https://www.freshports.org/lang/julia10/ There is already a review in progress - please consider collaborating there, or at least open a new review since this is a lengthy patch to review here. https://reviews.freebsd.org/D29359 (In reply to Guangyuan Yang from comment #4) Oh sorry i had not seen that. How do collaborate with them. (In reply to Eric Reardon from comment #5) After another look, the original review seems stale for a while. I suggest that the first thing to do is to create a Phabricator account if you haven't had one, and post your patch to a new review. Feel free to tag all relevant personnel so we could take a closer look. (In reply to Guangyuan Yang from comment #6) Thank you, i will start in the morning. Created attachment 230057 [details]
Update to julia-1.7.0
Here is the patch to update to 1.7.0 release.
The patch set USE_SYSTEM_P7ZIP=0, better set USE_SYSTEM_P7ZIP=1.
(In reply to Wen Heping from comment #8) Thank you, but my patches at the top are a bit stale, If you would like to see my fresh patches there over here. https://reviews.freebsd.org/D33121 Is it ready for importing into portstree ? wen |
Created attachment 229715 [details] lang/julia patches This is based on the deleted lang/julia10 from ports with modifications by me. Poudriere testport: passing on FreeBSD 12.2-RELEASE amd64 with default OPTIONS passing on FreeBSD 12.2-RELEASE amd64 with all OPTIONS enabled passing on FreeBSD 13.0-RELEASE amd64 with default OPTIONS passing on FreeBSD 13.0-RELEASE amd64 with all OPTIONS enabled I will have i386 working as soon as i can. Other archs are not (yet) supported up stream for FreeBSD. This is the third release candidate but the FreeBSD support is good.