|Product:||Ports & Packages||Reporter:||Eric Reardon <rizor.reardon>|
|Component:||Individual Port(s)||Assignee:||freebsd-ports-bugs (Nobody) <ports-bugs>|
|Severity:||Affects Only Me||CC:||mikael, rizor.reardon, wen, ygy|
|Priority:||---||Keywords:||feature, needs-patch, needs-qa|
Description Eric Reardon 2021-11-24 23:20:04 UTC
Created attachment 229715 [details] lang/julia patches This is based on the deleted lang/julia10 from ports with modifications by me. Poudriere testport: passing on FreeBSD 12.2-RELEASE amd64 with default OPTIONS passing on FreeBSD 12.2-RELEASE amd64 with all OPTIONS enabled passing on FreeBSD 13.0-RELEASE amd64 with default OPTIONS passing on FreeBSD 13.0-RELEASE amd64 with all OPTIONS enabled I will have i386 working as soon as i can. Other archs are not (yet) supported up stream for FreeBSD. This is the third release candidate but the FreeBSD support is good.
Comment 1 Kubilay Kocak 2021-11-25 00:42:28 UTC
Thank you Eric. Can you in addition to the full patch already included, produce and attach a diff against the last git version of lang/julia10 so we can review the delta. If you can confirm the port passes QA as well (portlint, poudriere at least), that'd also be great. #freebsd-ports on Libera.Chat IRC if you need help/support getting that running
Comment 2 Kubilay Kocak 2021-11-25 00:43:12 UTC
Aaaand, I missed that QA had been confirmed, cancel last request (modulo the delta diff), apologies :)
Comment 3 Eric Reardon 2021-11-25 00:55:38 UTC
lang/julia10 was deleted back in the svn port days, is there a way to make a git diff. https://www.freshports.org/lang/julia10/
Comment 4 Guangyuan Yang 2021-11-25 04:04:16 UTC
There is already a review in progress - please consider collaborating there, or at least open a new review since this is a lengthy patch to review here. https://reviews.freebsd.org/D29359
Comment 5 Eric Reardon 2021-11-25 04:33:35 UTC
(In reply to Guangyuan Yang from comment #4) Oh sorry i had not seen that. How do collaborate with them.
Comment 6 Guangyuan Yang 2021-11-25 05:08:41 UTC
(In reply to Eric Reardon from comment #5) After another look, the original review seems stale for a while. I suggest that the first thing to do is to create a Phabricator account if you haven't had one, and post your patch to a new review. Feel free to tag all relevant personnel so we could take a closer look.
Comment 7 Eric Reardon 2021-11-25 05:34:34 UTC
(In reply to Guangyuan Yang from comment #6) Thank you, i will start in the morning.
Comment 8 Wen Heping 2021-12-12 13:09:27 UTC
Created attachment 230057 [details] Update to julia-1.7.0 Here is the patch to update to 1.7.0 release. The patch set USE_SYSTEM_P7ZIP=0, better set USE_SYSTEM_P7ZIP=1.
Comment 9 Eric Reardon 2021-12-14 19:21:34 UTC
(In reply to Wen Heping from comment #8) Thank you, but my patches at the top are a bit stale, If you would like to see my fresh patches there over here. https://reviews.freebsd.org/D33121
Comment 10 Wen Heping 2021-12-25 06:39:29 UTC
Is it ready for importing into portstree ? wen