Bug 260190
| Summary: | finance/chiapos: Update to 1.0.7 | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | risner <risner> | ||||||||||
| Component: | Individual Port(s) | Assignee: | freebsd-ports-bugs (Nobody) <ports-bugs> | ||||||||||
| Status: | Open --- | ||||||||||||
| Severity: | Affects Only Me | CC: | bofh, cs, fuz, lwhsu, python, risner | ||||||||||
| Priority: | --- | Keywords: | needs-qa | ||||||||||
| Version: | Latest | Flags: | koobs:
maintainer-feedback?
(risner) |
||||||||||
| Hardware: | Any | ||||||||||||
| OS: | Any | ||||||||||||
| Attachments: |
|
||||||||||||
^Triage: Please set the maintainer-approval attachment flag (to +) on patches for ports you maintain to signify approval.
Attachment -> Details -> maintainer-approval [+]
Review items:
Upstream appears to have released 1.0.7 [1], which adds 3.10 support.
Accordingly, USES=python:<version-spec> should be scoped to match supported Python versions in the current chiapos port version (3.7-3.9) as a separate commit (and merged) prior to the version update (bumping to 3.7-3.10 for second commit, please update patch)
For the following changes in setup.py:
- tests_require=["pytest"],
- ext_modules=[CMakeExtension("chiapos", ".")],
removing tests_require shouldn't be necessary, and for the latter change, can that be replaced with removing the bundled chiapos sources?
[1] https://github.com/Chia-Network/chiapos/releases/tag/1.0.7
Created attachment 229870 [details]
updated to 1.0.7
funny, I make the patch for 1.0.6 and 2 hours later they release 1.0.7.
Created attachment 229871 [details]
correct 1.0.7 patch
updated to 1.0.7, correct file.
(In reply to Kubilay Kocak from comment #1) >1.0.7 [1], which adds 3.10 support. >Accordingly, USES=python:<version-spec> should be scoped to match supported I had been advised of issues with FreeBSD's framework with ports containing both cmake and python, so this port has no python bits. >removing tests_require shouldn't be necessary, and for the latter change, can that be replaced with removing the bundled chiapos sources? I reversed the removal of the tests_require line. However you bring up a good point. Do I even need the setup.py file in this port? Should I remove the entire file? I could update the patch to delete setup.py. I left the file and edited some things previously because it annoyed me they typed the project name in the setup.py file. (In reply to risner from comment #4) Right I forgot. Separate chiapos / py-chiapos ports is fine It's OK not to remove files that aren't used in build. Just remove patches that are unnecessary. Could you also explain the patch file changes/removals. This will help committer explain (why) them. Ideally, just post an appropriate commit log message correctly and completely formatted as a comment Created attachment 229930 [details]
Patch for 1.0.7
Updated to 1.0.7.
I removed the files/Hellman-Makefile because it had been up streamed and on advice I removed the setup.py changes as they are not relevant for the cmake half of this distribution file.
FreeBSD framework has conflicts when a package has cmake and python products, so we need to split them into two ports. This is the cmake half.
(In reply to risner from comment #6) Can confirm this all passes QA? * portlint: ?? * testport: ?? (poudriere: freebsd <version/arch>, py*) * maketest: ?? (In reply to risner from comment #6) patch-setup.py failed to apply. If we're going to separate a py-chiapos port, I think we can remove it in this port and put in py- one. A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=b07dc5dfbc850add00ba0e6f685f3819a9f5fe42 commit b07dc5dfbc850add00ba0e6f685f3819a9f5fe42 Author: Carlo Strub <cs@FreeBSD.org> AuthorDate: 2022-10-09 14:37:06 +0000 Commit: Carlo Strub <cs@FreeBSD.org> CommitDate: 2022-10-09 14:37:06 +0000 devel/py-python-gitlab: Update to 3.10.0 PR: 260190 Reported by: maintainer devel/py-python-gitlab/Makefile | 2 +- devel/py-python-gitlab/distinfo | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) wrong action, sorry Please add a ONLY_FOR_ARCHS_REASON if possible. If the port is not supported on 32 bit architectures in general, also add the other 32 bit architectures currently supported by FreeBSD (armv6, armv7, mips, powerpc). Your patch fails during the "patch" phase: ===> Patching for chiapos-1.0.7 ===> Applying FreeBSD patches for chiapos-1.0.7 from /usr/home/main.ports/finance/chiapos/files 1 out of 3 hunks failed--saving rejects to setup.py.rej ===> FAILED Applying FreeBSD patch-setup.py ===> Cleanly applied FreeBSD patch(es) patch-CMakeLists.txt ===> FAILED to apply cleanly FreeBSD patch(es) patch-setup.py Please check and resubmit. Can you please submit a refreshed patch? And I am not sure why the patch path is mentioned as finance/chiapos-1.0.3. It should be finance/chiapos. |
Created attachment 229862 [details] patch to bring finance/chiapos to 1.0.6 updated