Bug 260224

Summary: games/xnethack
Product: Ports & Packages Reporter: wesley.a.wroten <wesley.a.wroten>
Component: Individual Port(s)Assignee: Mikael Urankar <mikael>
Status: Closed FIXED    
Severity: Affects Only Me CC: fuz, mikael
Priority: --- Flags: fuz: maintainer-feedback+
fuz: merge-quarterly?
Version: Latest   
Hardware: amd64   
OS: Any   
Attachments:
Description Flags
games/xnethack: fix wrong lua version fuz: maintainer-approval+

Description wesley.a.wroten@gmail.com 2021-12-05 01:20:17 UTC 
Both installing this port by pkg or compiling via the ports tree generates the same lua errors, causing the game to quit.
Here are the errors:
1) luaL_loadbuffer: Error loading (nhlib.lua): [string "(nhlib.lua)"]:71: 'end'
expected (to close 'function' at line 54) near '|'

2) 'nhl_init' failed; can't continue.

This bug may be reproduced by installing or compiling xnethack and running the program.
Comment 1 Robert Clausecker 2021-12-05 12:33:01 UTC 
Created attachment 229926 [details]
games/xnethack: fix wrong lua version

games/xnethack: fix wrong lua version

The game calls for lua 5.4, so USES=lua:54 when unbundling lua (PR #260224).

While we are at it:

 - turn games/nethack-nox11 into flavor games/nethack@nox11
 - simplify Makefile
 - remove archaic pkg-deinstall.in; it's function is superseeded by
   messages pkg-deinstall(8) prints on its own

Tested with Poudriere on i386 amd64 armv7 arm64 FreeBSD 13.
Comment 2 commit-hook freebsd_committer 2021-12-16 20:07:25 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=e8cf9c4dafb78dbcd0e3c88e67fc1e626afea44e

commit e8cf9c4dafb78dbcd0e3c88e67fc1e626afea44e
Author:     Robert Clausecker <fuz@fuz.su>
AuthorDate: 2021-12-05 12:20:45 +0000
Commit:     Mikael Urankar <mikael@FreeBSD.org>
CommitDate: 2021-12-16 20:06:31 +0000

    games/xnethack: fix wrong lua version

    The game calls for lua 5.4, so USES=lua:54 when unbundling lua (PR #260224).

    While we are at it:

     - turn games/nethack-nox11 into flavor games/nethack@nox11
     - simplify Makefile
     - remove archaic pkg-deinstall.in; it's function is superseeded by
       messages pkg-deinstall(8) prints on its own

    PR:             260224
    Reported by:    wesley.a.wroten@gmail.com

 MOVED                                            |  1 +
 games/Makefile                                   |  1 -
 games/xnethack-nox11/Makefile (gone)             |  7 ----
 games/xnethack/Makefile                          | 43 +++++++-----------------
 games/xnethack/files/patch-doc_dlb.6             |  2 +-
 games/xnethack/files/patch-doc_nethack.6         |  2 +-
 games/xnethack/files/patch-doc_recover.6         |  2 +-
 games/xnethack/files/patch-sys-unix-Makefile.doc | 10 +++---
 games/xnethack/files/patch-sys-unix-Makefile.src |  2 +-
 games/xnethack/files/patch-sys-unix-Makefile.top |  2 +-
 games/xnethack/files/pkg-deinstall.in (gone)     | 14 --------
 games/xnethack/pkg-plist                         |  1 -
 12 files changed, 23 insertions(+), 64 deletions(-)