Summary: | security/p5-openxpki*: Update to 3.16.1 | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Sergei Vyshenski <svysh.fbsd> | ||||||
Component: | Individual Port(s) | Assignee: | Dries Michiels <driesm> | ||||||
Status: | Closed FIXED | ||||||||
Severity: | Affects Some People | CC: | driesm, svysh.fbsd | ||||||
Priority: | --- | ||||||||
Version: | Latest | ||||||||
Hardware: | Any | ||||||||
OS: | Any | ||||||||
URL: | https://github.com/openxpki/openxpki/compare/v3.16.0...v3.16.1 | ||||||||
Attachments: |
|
Description
Sergei Vyshenski
2021-12-05 02:08:26 UTC
Take Hello Sergei, thanks for the patch! Please don't follow output of linting tools blindly. Take a look at the diff after portfmt which suggest to wrap those lines. Do you think its more readable? (I don't think so at all ...), reason is that the MY_DEPEND keyword is missing from the rules section (see link below). https://github.com/t6/portfmt/blob/main/rules.c Please create a Pull Request to add the MY_DEPENDS keyword. It should be handled the same way as BUILD_DEPENDS or RUN_DEPENDS or LIB_DEPENDS, which always starts a new line for each entry. As such (an entry above BUILD_DEPENDS): { BLOCK_DEPENDS, "MY_DEPENDS", VAR_PRINT_AS_NEWLINES | VAR_SORTED, {} }, VAR_FOR_EACH_ARCH(BLOCK_DEPENDS, "MY_DEPENDS_", VAR_PRINT_AS_NEWLINES | VAR_SKIP_GOALCOL | VAR_SORTED, {}), Tobik is very pleased to receive PR's. Created attachment 229970 [details]
"git diff" to update two ports
Ok, thanks, will do it.
Meanwhile please find a new patch.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=86723e299a49a4dc827534f65c9e3676bdd519ce commit 86723e299a49a4dc827534f65c9e3676bdd519ce Author: Sergei Vyshenski <svysh.fbsd@gmail.com> AuthorDate: 2021-12-08 19:59:35 +0000 Commit: Dries Michiels <driesm@FreeBSD.org> CommitDate: 2021-12-13 17:21:59 +0000 security/p5-openxpki: Update to 3.16.1 Changes: https://github.com/openxpki/openxpki/compare/v3.16.0...v3.16.1 PR: 260226 Approved by: 0mp (mentor) Differential Revision: https://reviews.freebsd.org/D33383 security/p5-openxpki/Makefile | 2 +- security/p5-openxpki/distinfo | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=3c01d8800e8c404f6ba8f9e5c46aa38ef46d09e8 commit 3c01d8800e8c404f6ba8f9e5c46aa38ef46d09e8 Author: Sergei Vyshenski <svysh.fbsd@gmail.com> AuthorDate: 2021-12-08 20:01:40 +0000 Commit: Dries Michiels <driesm@FreeBSD.org> CommitDate: 2021-12-13 17:21:59 +0000 security/p5-openxpki-i18n: Update to 3.16.1 Changes: https://github.com/openxpki/openxpki/compare/v3.16.0...v3.16.1 PR: 260226 Approved by: 0mp (mentor) Differential Revision: https://reviews.freebsd.org/D33382 security/p5-openxpki-i18n/Makefile | 2 +- security/p5-openxpki-i18n/distinfo | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) Committed, thanks! Looking forward to the Pull Request for portfmt ... :) |