Bug 260425
| Summary: | multimedia/get_iplayer: Update to 3.28 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Jamie Landeg-Jones <jamie> | ||||||
| Component: | Individual Port(s) | Assignee: | Neel Chauhan <nc> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Some People | CC: | danfe, jamie, nc, ygy | ||||||
| Priority: | --- | Flags: | jamie:
maintainer-feedback+
|
||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
Could you please submit "git diff" or "git format-patch" patches? I am honestly not sure how to process this file... A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=0c02e7166da869a56bf7614272a8b9c6e9248158 commit 0c02e7166da869a56bf7614272a8b9c6e9248158 Author: Jamie Landeg-Jones <jamie@catflap.org> AuthorDate: 2021-12-15 03:37:39 +0000 Commit: Neel Chauhan <nc@FreeBSD.org> CommitDate: 2021-12-15 03:37:39 +0000 multimedia/get_iplayer: Update to 3.28 PR: 260425 multimedia/get_iplayer/Makefile | 2 +- multimedia/get_iplayer/distinfo | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) (In reply to Guangyuan Yang from comment #1) It's a basic "patch" file - the same format that has been used for at least the 15 years I've been maintaining ports. cd /usr/ports/multimedia/get_iplayer && patch < file Has this changed now? I hate git. If developers prefer it, then who am I to argue? They use it everyday, so what works best for them is none of my business. But if we are required do use git for basic ports maintenance (especially when we don't have direct commit access) then please remove my maintainership of the port. Thanks (In reply to Neel Chauhan) Cheers! (In reply to Guangyuan Yang from comment #1) Please delete/ignore my previous rant. Created attachment 230145 [details]
patch -d /usr/ports/multimedia/get_iplayer < FILENAME
Neels, sorry for the spam. Could you please also commit this small fix to a spelling mistake introduced elsewhere.
No need for a version bump.
Thanks, Jamie
Done! A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=d88c27daea62ad5b5251ebbdd4ec2dc14f6dc9f1 commit d88c27daea62ad5b5251ebbdd4ec2dc14f6dc9f1 Author: Jamie Landeg-Jones <jamie@catflap.org> AuthorDate: 2021-12-15 17:22:14 +0000 Commit: Neel Chauhan <nc@FreeBSD.org> CommitDate: 2021-12-15 17:22:14 +0000 multimedia/get_iplayer: Fix comment PR: 260425 multimedia/get_iplayer/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Thanks Neel! (In reply to Jamie Landeg-Jones from comment #3) > Has this changed now? No, it hasn't. We gladly accept any patches in any consumable format. It is our responsibility as developers to know how to handle all of them. Being honestly not sure how to process a simple patch is preposterous. > I hate git. Me too. > If developers prefer it, then who am I to argue? Some of us don't, but it had been forced upon us. :( > But if we are required do use git for basic ports maintenance No, port maintainers are not required to use git. It's up to them how to keep their ports tree updated. |
Created attachment 230125 [details] patch to makefile and distinfo Maintainer update to latest version