Bug 260506

Summary: x11-themes/canta-gtk-themes: Fix xfwm4 theme
Product: Ports & Packages Reporter: Alexander Vereeken <Alexander88207>
Component: Individual Port(s)Assignee: Robert Clausecker <fuz>
Status: Closed FIXED    
Severity: Affects Some People CC: fuz, grahamperrin
Priority: --- Flags: Alexander88207: maintainer-feedback+
fuz: merge-quarterly+
Version: Latest   
Hardware: Any   
OS: Any   
URL: https://www.freshports.org/x11-themes/canta-gtk-themes/
Attachments:
Description Flags
canta-gtk-themes-2021.09.08_1.diff
none
canta-gtk-themes-2021.09.08_1.diff(v2)
Alexander88207: maintainer-approval+
canta-gtk-themes-2021.09.08_1.diff(v3) Alexander88207: maintainer-approval+

Description Alexander Vereeken 2021-12-17 21:34:50 UTC
Created attachment 230212 [details]
canta-gtk-themes-2021.09.08_1.diff

Hello,

the xfwm4 theme remains canta-dark no matter which wm theme you choose from canta. 

A patch have been attached.

Thank you in advance!
Comment 1 Alexander Vereeken 2021-12-17 21:39:27 UTC
Created attachment 230213 [details]
canta-gtk-themes-2021.09.08_1.diff(v2)
Comment 2 Alexander Vereeken 2021-12-17 21:46:45 UTC
Created attachment 230214 [details]
canta-gtk-themes-2021.09.08_1.diff(v3)

While here tweak pkg-descr accordingly to the other theme ports that i maintain.
Comment 3 Robert Clausecker freebsd_committer freebsd_triage 2023-05-22 11:52:40 UTC
Thank you for your submission.
I'm sorry it took so long for this to be processed.  Will commit with my next batch.
Comment 4 Robert Clausecker freebsd_committer freebsd_triage 2023-05-22 11:54:10 UTC
Are you ok with this being merged into the quarterly (2023Q2) branch?
Comment 5 Alexander Vereeken 2023-05-22 13:50:05 UTC
Thank you!

Yes i am ok with that.
Comment 6 commit-hook freebsd_committer freebsd_triage 2023-05-25 09:45:00 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=fc8585d9420f0b1b0ebf922810cccbaa81400844

commit fc8585d9420f0b1b0ebf922810cccbaa81400844
Author:     Alexander Vereeken <Alexander88207@protonmail.com>
AuthorDate: 2023-05-22 11:53:00 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2023-05-25 09:39:32 +0000

    x11-themes/canta-gtk-themes: Fix xfwm4 theme

    Fix bug where the xfwm4 theme remains canta-dark no matter which
    wm theme you choose from canta.  While here tweak pkg-descr accordingly
    to the other theme ports that i maintain.

    PR:             260506
    MFH:            2023Q2

 x11-themes/canta-gtk-themes/Makefile               |   2 +
 x11-themes/canta-gtk-themes/files/patch-install.sh | 181 ++++++++++++++++++++-
 x11-themes/canta-gtk-themes/pkg-descr              |   9 +
 3 files changed, 183 insertions(+), 9 deletions(-)
Comment 7 commit-hook freebsd_committer freebsd_triage 2023-05-25 09:46:03 UTC
A commit in branch 2023Q2 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=e767fc1dfee4e9e49844614a4e40005acd2033af

commit e767fc1dfee4e9e49844614a4e40005acd2033af
Author:     Alexander Vereeken <Alexander88207@protonmail.com>
AuthorDate: 2023-05-22 11:53:00 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2023-05-25 09:45:24 +0000

    x11-themes/canta-gtk-themes: Fix xfwm4 theme

    Fix bug where the xfwm4 theme remains canta-dark no matter which
    wm theme you choose from canta.  While here tweak pkg-descr accordingly
    to the other theme ports that i maintain.

    PR:             260506
    MFH:            2023Q2
    (cherry picked from commit fc8585d9420f0b1b0ebf922810cccbaa81400844)

 x11-themes/canta-gtk-themes/Makefile               |   2 +
 x11-themes/canta-gtk-themes/files/patch-install.sh | 181 ++++++++++++++++++++-
 x11-themes/canta-gtk-themes/pkg-descr              |   9 +
 3 files changed, 183 insertions(+), 9 deletions(-)
Comment 8 Robert Clausecker freebsd_committer freebsd_triage 2023-05-25 09:51:56 UTC
Thank you for your submission.