Bug 260651
| Summary: | www/node16: Fix build on armv7 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Brad Davis <brd> | ||||||
| Component: | Individual Port(s) | Assignee: | Mikael Urankar <mikael> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Many People | CC: | bhughes, fuz, mikael | ||||||
| Priority: | --- | Keywords: | needs-qa | ||||||
| Version: | Latest | Flags: | bugzilla:
maintainer-feedback?
(bhughes) koobs: merge-quarterly? |
||||||
| Hardware: | arm | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
These patches work on www/node just fine. Created attachment 230380 [details]
node14 patch
Add regenerated patch for node14.
^Triage: Build fixes are: Approved by: portmgr (blanket: build fix) MFH: 2022Q1 (blanket: build fix) Comment on attachment 230380 [details]
node14 patch
Add comments to patch headers with summary description and upstream reference (issues, prs, commits) links if relevent.
Are these, or should these patches go upstream?
On ports approval, if these changes pass QA (in particular: poudriere for both armv7 and !armv7 archs):
Approved by: koobs (ports)
@Brad, could you address the points raised by koobs in comments #4? I'd really like to have this patch in. We've already missed the 2022Q2 window. A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=a5889a8d98e5f652723d1a67f0f414347675cadd commit a5889a8d98e5f652723d1a67f0f414347675cadd Author: Mikael Urankar <mikael@FreeBSD.org> AuthorDate: 2022-04-19 16:30:10 +0000 Commit: Mikael Urankar <mikael@FreeBSD.org> CommitDate: 2022-04-19 16:42:44 +0000 www/node16: Fix build on armv7 PR: 260651 Approved by: portmgr (build fix blanket) ...h-deps_v8_src_base_platform_platform-freebsd.cc | 49 ---------------------- .../patch-deps_v8_src_codegen_arm_cpu-arm.cc (new) | 18 ++++++++ 2 files changed, 18 insertions(+), 49 deletions(-) A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=1a35a43cfc1e77557381b50fff7b528ba9f9835a commit 1a35a43cfc1e77557381b50fff7b528ba9f9835a Author: Mikael Urankar <mikael@FreeBSD.org> AuthorDate: 2022-04-19 16:29:29 +0000 Commit: Mikael Urankar <mikael@FreeBSD.org> CommitDate: 2022-04-19 16:42:43 +0000 www/node14: Fix build on armv7 PR: 260651 Approved by: portmgr (build fix blanket) ...h-deps_v8_src_base_platform_platform-freebsd.cc | 49 ---------------------- .../patch-deps_v8_src_codegen_arm_cpu-arm.cc (new) | 18 ++++++++ 2 files changed, 18 insertions(+), 49 deletions(-) A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=02c4b2720bb1b5a0c0af5617b1e1dfd2e040f60d commit 02c4b2720bb1b5a0c0af5617b1e1dfd2e040f60d Author: Mikael Urankar <mikael@FreeBSD.org> AuthorDate: 2022-04-19 16:22:38 +0000 Commit: Mikael Urankar <mikael@FreeBSD.org> CommitDate: 2022-04-19 16:42:43 +0000 www/node: Fix build on armv7 PR: 260651 Approved by: portmgr (build fix blanket) ...h-deps_v8_src_base_platform_platform-freebsd.cc | 49 ---------------------- .../patch-deps_v8_src_codegen_arm_cpu-arm.cc (new) | 18 ++++++++ 2 files changed, 18 insertions(+), 49 deletions(-) A commit in branch 2022Q2 references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=dc11ba0ae68be80ab0bdbd8b215cb8834d1a9d88 commit dc11ba0ae68be80ab0bdbd8b215cb8834d1a9d88 Author: Mikael Urankar <mikael@FreeBSD.org> AuthorDate: 2022-04-19 16:22:38 +0000 Commit: Mikael Urankar <mikael@FreeBSD.org> CommitDate: 2022-04-19 16:44:28 +0000 www/node: Fix build on armv7 PR: 260651 Approved by: portmgr (build fix blanket) (cherry picked from commit 02c4b2720bb1b5a0c0af5617b1e1dfd2e040f60d) ...h-deps_v8_src_base_platform_platform-freebsd.cc | 49 ---------------------- .../patch-deps_v8_src_codegen_arm_cpu-arm.cc (new) | 18 ++++++++ 2 files changed, 18 insertions(+), 49 deletions(-) A commit in branch 2022Q2 references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=f7a0bc48efc91e1c8089d29ca9dbc0d4ebf5abe7 commit f7a0bc48efc91e1c8089d29ca9dbc0d4ebf5abe7 Author: Mikael Urankar <mikael@FreeBSD.org> AuthorDate: 2022-04-19 16:29:29 +0000 Commit: Mikael Urankar <mikael@FreeBSD.org> CommitDate: 2022-04-19 16:44:24 +0000 www/node14: Fix build on armv7 PR: 260651 Approved by: portmgr (build fix blanket) (cherry picked from commit 1a35a43cfc1e77557381b50fff7b528ba9f9835a) ...h-deps_v8_src_base_platform_platform-freebsd.cc | 49 ---------------------- .../patch-deps_v8_src_codegen_arm_cpu-arm.cc (new) | 18 ++++++++ 2 files changed, 18 insertions(+), 49 deletions(-) A commit in branch 2022Q2 references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=fe1a806a63b25c9228841cf292bff98a23f42b6c commit fe1a806a63b25c9228841cf292bff98a23f42b6c Author: Mikael Urankar <mikael@FreeBSD.org> AuthorDate: 2022-04-19 16:30:10 +0000 Commit: Mikael Urankar <mikael@FreeBSD.org> CommitDate: 2022-04-19 16:44:20 +0000 www/node16: Fix build on armv7 PR: 260651 Approved by: portmgr (build fix blanket) (cherry picked from commit a5889a8d98e5f652723d1a67f0f414347675cadd) ...h-deps_v8_src_base_platform_platform-freebsd.cc | 49 ---------------------- .../patch-deps_v8_src_codegen_arm_cpu-arm.cc (new) | 18 ++++++++ 2 files changed, 18 insertions(+), 49 deletions(-) |
Created attachment 230362 [details] patch This likely applies to all versions of node. I can test on those if needed.