Bug 260678

Summary: mail/exim-4.94.2_1 fails to build after upgrade of opendmarc to 1.4.2
Product: Ports & Packages Reporter: lysfjord.daniel
Component: Individual Port(s)Assignee: Dima Panov <fluffy>
Status: Closed FIXED    
Severity: Affects Only Me CC: ler
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
poudriere build log for mail/exim-4.94.2_1 none

Description lysfjord.daniel 2021-12-25 12:53:27 UTC
Created attachment 230390 [details]
poudriere build log for mail/exim-4.94.2_1

mail/exim fails to build after opendmarc upgrade to 1.4.2 with the following error:

dmarc.c:449:30: error: too few arguments to function call, expected 5, have 4
                                               dkim_result, US"");
                                                                ^
/usr/local/include/opendmarc/dmarc.h:125:1: note: 'opendmarc_policy_store_dkim' declared here
OPENDMARC_STATUS_T opendmarc_policy_store_dkim(DMARC_POLICY_T *pctx, u_char *domain, u_char *selector, int result, u_char *human_result);
^
/usr/local/include/opendmarc/dmarc.h:88:28: note: expanded from macro 'OPENDMARC_STATUS_T'
#define OPENDMARC_STATUS_T int
Comment 1 Larry Rosenman freebsd_committer freebsd_triage 2021-12-25 17:39:18 UTC
I reported this via private mail to fluffy@ last night.  He says it will be taken care of today (25-Dec-2021).

Assigned this PR to him.
Comment 2 commit-hook freebsd_committer freebsd_triage 2021-12-25 20:37:27 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ed253c0553af2883c5d4d4d28d5cf9740f768459

commit ed253c0553af2883c5d4d4d28d5cf9740f768459
Author:     Dima Panov <fluffy@FreeBSD.org>
AuthorDate: 2021-12-25 20:28:18 +0000
Commit:     Dima Panov <fluffy@FreeBSD.org>
CommitDate: 2021-12-25 20:28:18 +0000

    mail/exim: unbreak after mail/opendmarc update (+)

    Last update for mail/opendmarc to 1.4.2  changes required params for
    opendmarc_policy_store_dkim subroutine by introducing *dkim_selector
    as pair for *domain.

    Adjust exim' dmarc routines by pass NULL string as *dkim_selector to
    force opendmarc subroutine go thru autodetect required selector on the fly.

    This dirt'n'ugly hack will be dropped as soon as functionality will be
    adjusted upstream in proper way.

    Bump PORTREVISION to force rebuild.

    Reported by:    ler, poudriere failure
    PR:             260678

 mail/exim/Makefile                      |  2 +-
 mail/exim/files/patch-src-dmarc.c (new) | 19 +++++++++++++++++++
 2 files changed, 20 insertions(+), 1 deletion(-)
Comment 3 Dima Panov freebsd_committer freebsd_triage 2021-12-25 21:42:42 UTC
Fixed