Bug 260920

Summary: net-p2p/radarr: Upgrade to 4.0.2.5836
Product: Ports & Packages Reporter: Michiel van Baak Jansen <michiel>
Component: Individual Port(s)Assignee: Guangyuan Yang <ygy>
Status: Closed FIXED    
Severity: Affects Some People CC: mikael, ygy
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
URL: https://github.com/Radarr/Radarr/releases/tag/v4.0.2.5836
See Also: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=259194
Bug Depends on: 259194    
Bug Blocks:    
Attachments:
Description Flags
0001-net-p2p-radarr-Update-to-4.0.0.5745.patch
none
poudriere testport log 13.0 amd64
none
0001-net-p2p-radarr-Update-to-4.0.0.5745.patch
none
poudriere testport logs
none
0001-net-p2p-radarr-Update-to-4.0.1.5813.patch
none
0001-net-p2p-radarr-Update-to-4.0.2.5836.patch
none
0001-net-p2p-radarr-Update-to-4.0.2.5836.patch
none
0001-net-p2p-radarr-Update-to-4.0.2.5836.patch michiel: maintainer-approval+

Description Michiel van Baak Jansen 2022-01-04 12:11:48 UTC
Created attachment 230682 [details]
0001-net-p2p-radarr-Update-to-4.0.0.5745.patch

With version 4, the radarr project dropped mono support.
This port uses the .NET6 compiled version. See https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=259194 for more background and discussion about some of the changes in the port.

radarr uses a modified build of ffprobe, so the port cannot depend on multimedia/ffmpeg for it.
If the bundled ffprobe is installed with $INSTALL_PROGRAM, it gets stripped and that breaks the binary. That's why it's installed with $INSTALL_SCRIPT

poudriere testport ok (see log)
Runs in my setup (13.0 amd64 jail with vnet and ipv6)
Comment 1 Michiel van Baak Jansen 2022-01-04 12:12:38 UTC
Created attachment 230683 [details]
poudriere testport log 13.0 amd64
Comment 2 Michiel van Baak Jansen 2022-01-04 13:58:35 UTC
Created attachment 230687 [details]
0001-net-p2p-radarr-Update-to-4.0.0.5745.patch

- the bundled ffprobe actually works when installed with INSTALL_PROGRAM.
- Fix typo in Makefile so it does not copy ffprobe 2 times

Poudriere testport ok
Runs on my system (13.0 amd64)
Comment 3 Michiel van Baak Jansen 2022-01-04 14:02:23 UTC
Created attachment 230688 [details]
poudriere testport logs
Comment 4 Michiel van Baak Jansen 2022-01-12 14:05:49 UTC
Created attachment 230953 [details]
0001-net-p2p-radarr-Update-to-4.0.1.5813.patch
Comment 5 Michiel van Baak Jansen 2022-01-17 15:10:45 UTC
Created attachment 231077 [details]
0001-net-p2p-radarr-Update-to-4.0.2.5836.patch

Update to latest pre-release.

testport ok
runtest ok
Comment 6 Michiel van Baak Jansen 2022-01-19 16:30:46 UTC
Created attachment 231163 [details]
0001-net-p2p-radarr-Update-to-4.0.2.5836.patch

Same as previous patch with the addition that now built-in updates are disabled.
The user is told about this during install, with instructions on how to enable the built-in updates again, and a warning why this is not a good idea.

testport ok
runs on my production setup (13.0 amd64)
Comment 7 Michiel van Baak Jansen 2022-01-25 12:51:44 UTC
Created attachment 231313 [details]
0001-net-p2p-radarr-Update-to-4.0.2.5836.patch

Dont chown the binaries directory. If the user wants to enable the built-in updater, they should chown the directory themselves.
Document this in the pkg-message

Same patch has been created for sonarr (https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=261340) and prowlarr (https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=261465)


poudriere ok
runtest ok
Runs in 'production' here (13.0-amd64)
Comment 8 commit-hook freebsd_committer freebsd_triage 2022-01-28 15:25:52 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=bb4eddeb3b2fc84306dafe07ccceb501ab72a504

commit bb4eddeb3b2fc84306dafe07ccceb501ab72a504
Author:     Michiel van Baak Jansen <michiel@vanbaak.eu>
AuthorDate: 2022-01-28 15:25:12 +0000
Commit:     Guangyuan Yang <ygy@FreeBSD.org>
CommitDate: 2022-01-28 15:25:12 +0000

    net-p2p/radarr: Update to 4.0.2.5836

    Changelog:      https://github.com/Radarr/Radarr/releases/tag/v4.0.2.5836

    PR:             260920

 net-p2p/radarr/Makefile                    |   20 +-
 net-p2p/radarr/distinfo                    |    6 +-
 net-p2p/radarr/files/package_info.in (new) |    5 +
 net-p2p/radarr/files/pkg-message.in        |   12 +-
 net-p2p/radarr/files/radarr.in             |    4 +-
 net-p2p/radarr/pkg-plist                   | 1396 ++++++++++++++--------------
 6 files changed, 750 insertions(+), 693 deletions(-)