Bug 260927

Summary: www/squid: update to 5.3
Product: Ports & Packages Reporter: Pavel Timofeev <timp87>
Component: Individual Port(s)Assignee: Daniel Engberg <diizzy>
Status: Closed FIXED    
Severity: Affects Only Me CC: diizzy, ml, nc, sa.inbox
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
URL: http://www.squid-cache.org/Versions/v5/squid-5.3-RELEASENOTES.html
Attachments:
Description Flags
port patch
timp87: maintainer-approval+
port patch2 timp87: maintainer-approval+

Description Pavel Timofeev 2022-01-04 17:14:43 UTC 
Created attachment 230700 [details]
port patch

1. What's new comparing to 4.15:
- use gmake
- BDB deprecation in behalf of TDB
- official release notes are at http://www.squid-cache.org/Versions/v5/squid-5.3-RELEASENOTES.html, see "2. Major new features since Squid-4" if you concerned about upgrade from 4 to 5.

2. Dear port committed please retire www/squid-devel as there is no sense to keep it in ports tree now. I was using it to track 5 branch at the time it was soon to be released.

3. There were a number of vulnerabilities found in squid starting from 4.15 (current ports version) https://www.cvedetails.com/vulnerability-list/vendor_id-9950/product_id-17766/Squid-cache-Squid.html. See
- CVE-2021-28651
- CVE-2021-28652
- CVE-2021-28662
- CVE-2021-31806
- CVE-2021-31807
- CVE-2021-31808
- CVE-2021-33620
- CVE-2021-41611
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2022-01-06 02:53:46 UTC 
Update mirror list so it matches what upstream recommends

http://www.squid-cache.org/Download/http-mirrors.html
http://www.squid-cache.org/Download/mirrors.html

http://ca.squid-cache.org/Versions/v5/ --> Dead mirror

Sort USES

Instead of setting CFLAGS, LDFLAGS manually use the LOCALBASE helper (
https://docs.freebsd.org/en/books/porters-handbook/uses/#uses-localbase ).
You can also use OPT1_USES however looking at the Makeifle I'd suggest that you set it globally instead.
Comment 2 Pavel Timofeev 2022-01-06 21:57:02 UTC 
Created attachment 230763 [details]
port patch2
Comment 3 Pavel Timofeev 2022-01-10 16:19:40 UTC 
Is there anything else I can improve?
Comment 4 Daniel Engberg freebsd_committer freebsd_triage 2022-01-10 23:19:57 UTC 
I think it looks pretty good, I'm planning to have another look at it this week.
Comment 5 commit-hook freebsd_committer freebsd_triage 2022-01-19 10:13:29 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=d792ff1863af044ec543b679d5b0ed0e88614e51

commit d792ff1863af044ec543b679d5b0ed0e88614e51
Author:     Pavel Timofeev <timp87@gmail.com>
AuthorDate: 2022-01-19 10:11:37 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2022-01-19 10:11:41 +0000

    www/squid: update to 5.3: New port: Google Chat plugin for libpurple

    Changelog: http://www.squid-cache.org/Versions/v5/squid-5.3-RELEASENOTES.html

    PR:             260927

 www/squid/Makefile                        | 51 ++++++++-------------
 www/squid/distinfo                        |  6 +--
 www/squid/files/patch-compat_cpu.h        |  4 +-
 www/squid/files/patch-configure           | 75 ++++---------------------------
 www/squid/files/patch-include_squid.h     |  4 +-
 www/squid/files/patch-src-cf.data.pre     |  4 +-
 www/squid/files/patch-src_enums.h         |  2 +-
 www/squid/files/patch-src_ip_Intercept.cc |  4 +-
 www/squid/files/patch-src_tools.cc        |  4 +-
 www/squid/pkg-plist                       | 57 ++++++++++++++++++++---
 10 files changed, 92 insertions(+), 119 deletions(-)
Comment 6 Daniel Engberg freebsd_committer freebsd_triage 2022-01-19 10:14:47 UTC 
Sorry for the wait and the borked commit message :/
Thanks for your contribution