Bug 260962

Summary: sysutils/openzfs fsck.zfs(8) does not detect OpenZFS pool degradation
Product: Ports & Packages Reporter: Graham Perrin <grahamperrin>
Component: Individual Port(s)Assignee: freebsd-bugs (Nobody) <bugs>
Status: New ---    
Severity: Affects Only Me    
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
URL: https://cgit.freebsd.org/src/commit/sys/contrib/openzfs/cmd/fsck_zfs?id=1603881667360c015f6685131f2f25474fa67a72

Description Graham Perrin freebsd_committer freebsd_triage 2022-01-05 20:39:38 UTC 
<https://cgit.freebsd.org/src/tree/sys/contrib/openzfs/cmd/fsck_zfs>

Maybe not a bug, but what's below is not consistent with the installed manual page. 

----

root@mowa219-gjp4-8570p-freebsd:~ # zfs --version
zfs-2.1.99-FreeBSD_gf291fa658
zfs-kmod-2.1.99-FreeBSD_gf291fa658
root@mowa219-gjp4-8570p-freebsd:~ # /usr/local/sbin/fsck.zfs Transcend/VirtualBox
root@mowa219-gjp4-8570p-freebsd:~ # zpool status -x
  pool: Transcend
 state: ONLINE
status: One or more devices could not be opened.  Sufficient replicas exist for
        the pool to continue functioning in a degraded state.
action: Attach the missing device and online it using 'zpool online'.
   see: https://openzfs.github.io/openzfs-docs/msg/ZFS-8000-2Q
  scan: scrub repaired 0B in 01:32:30 with 0 errors on Sun Dec 12 16:25:35 2021
config:

        NAME                   STATE     READ WRITE CKSUM
        Transcend              ONLINE       0     0     0
          gpt/Transcend        ONLINE       0     0     0
        cache
          gpt/cache-transcend  UNAVAIL      0     0     0  cannot open

errors: No known data errors
root@mowa219-gjp4-8570p-freebsd:~ # date ; uname -aKU
Wed Jan  5 20:36:28 GMT 2022
FreeBSD mowa219-gjp4-8570p-freebsd 14.0-CURRENT FreeBSD 14.0-CURRENT #118 main-n251923-4bae154fe8c: Sat Dec 25 08:03:37 GMT 2021     root@mowa219-gjp4-8570p-freebsd:/usr/obj/usr/src/amd64.amd64/sys/GENERIC-NODEBUG  amd64 1400045 1400045
root@mowa219-gjp4-8570p-freebsd:~ # 

----

From    man 8 fsck.zfs

> … checks the status of a dataset's container pool.  It is installed 
> by OpenZFS because some Linux distributions expect a fsck helper for 
> all filesystems. …

> … if the dataset is in a degraded pool, then fsck.zfs will return 
> exit code 4 to indicate an uncorrected filesystem error. …
Comment 2 Andriy Gapon freebsd_committer freebsd_triage 2022-01-06 09:32:42 UTC 
> because some Linux distributions expect

But FreeBSD is not one.
Comment 3 Graham Perrin freebsd_committer freebsd_triage 2022-01-06 17:26:27 UTC 
(In reply to Andriy Gapon from comment #2)

Sure; if it's installed to FreeBSD then it should either: 

a) work (simply) as it does on Linux; or 

b) fail with an appropriate error. 

Thanks
Comment 4 Andriy Gapon freebsd_committer freebsd_triage 2022-01-07 08:21:39 UTC 
(In reply to Graham Perrin from comment #3)
My personal preference: do not install it on FreeBSD.