Bug 260986

Summary:

textproc/UCD: fails to fetch

Product:

Ports & Packages

Reporter:

Jan Beich <jbeich>

Component:

Individual Port(s)

Assignee:

Thierry Thomas <thierry>

Status:

Closed FIXED

Severity:

Affects Only Me

CC:

diizzy

Priority:

---

Keywords:

needs-patch

Version:

Latest

Flags:

bugzilla: maintainer-feedback? (thierry)

Hardware:

Any

OS:

Any

Attachments:

Description	Flags
Patch for UCD	none

Description Jan Beich freebsd_committer

2022-01-06 21:45:50 UTC

$ make checksum TRYBROKEN= MASTER_SITE_BACKUP= DISTDIR=$(mktemp -dt distfiles)
[...]
=> SHA256 Checksum mismatch for UCD-14.0.0/license.html.
[...]

or

$ poudriere testport -j 122amd64 textproc/UCD
[...]
=======================<phase: fetch          >============================
===== env: DEVELOPER_MODE=yes STRICT_DEPENDS=yes
===>  License Unicode_License_Agreement accepted by the user
===>   UCD-14.0.0 depends on file: /usr/local/sbin/pkg - found
=> UCD.zip doesn't seem to exist in /portdistfiles/UCD-14.0.0.
=> Attempting to fetch http://www.unicode.org/Public/zipped/14.0.0/UCD.zip
UCD.zip                                               6822 kB 1042 kBps    07s
=> license.html doesn't seem to exist in /portdistfiles/UCD-14.0.0.
=> Attempting to fetch http://www.unicode.org/license.html
license.html                                          2315  B 6197 kBps    00s
=> Unihan.zip doesn't seem to exist in /portdistfiles/UCD-14.0.0.
=> Attempting to fetch http://www.unicode.org/Public/zipped/14.0.0/Unihan.zip
Unihan.zip                                            6949 kB  948 kBps    07s
===> Fetching all distfiles required by UCD-14.0.0 for building
===========================================================================
=======================<phase: checksum       >============================
===== env: DEVELOPER_MODE=yes STRICT_DEPENDS=yes
===>  License Unicode_License_Agreement accepted by the user
===>   UCD-14.0.0 depends on file: /usr/local/sbin/pkg - found
===> Fetching all distfiles required by UCD-14.0.0 for building
=> SHA256 Checksum OK for UCD-14.0.0/UCD.zip.
=> SHA256 Checksum mismatch for UCD-14.0.0/license.html.
=> SHA256 Checksum OK for UCD-14.0.0/Unihan.zip.
===>  Refetch for 1 more times files:  UCD-14.0.0/license.html 
===>  License Unicode_License_Agreement accepted by the user
===>   UCD-14.0.0 depends on file: /usr/local/sbin/pkg - found
=> license.html doesn't seem to exist in /portdistfiles/UCD-14.0.0.
=> Attempting to fetch http://www.unicode.org/license.html
license.html                                          2315  B   43 MBps    00s
===> Fetching all distfiles required by UCD-14.0.0 for building
===>  License Unicode_License_Agreement accepted by the user
===>   UCD-14.0.0 depends on file: /usr/local/sbin/pkg - found
===> Fetching all distfiles required by UCD-14.0.0 for building
=> SHA256 Checksum OK for UCD-14.0.0/UCD.zip.
=> SHA256 Checksum mismatch for UCD-14.0.0/license.html.
=> SHA256 Checksum OK for UCD-14.0.0/Unihan.zip.
===>  Giving up on fetching files:  UCD-14.0.0/license.html 
Make sure the Makefile and distinfo file (/usr/ports/textproc/UCD/distinfo)
are up to date.  If you are absolutely sure you want to override this
check, type "make NO_CHECKSUM=yes [other args]".
*** Error code 1

Stop.
make[1]: stopped in /usr/ports/textproc/UCD
*** Error code 1

Comment 1 Daniel Engberg freebsd_committer

2022-01-07 20:52:08 UTC

Created attachment 230795 [details]
Patch for UCD

Only use HTTPS
Instead of creating a new directory for each release use a subdir.
Grab license file from Unicode Han Database (Unihan) as they share the same and are both part of Unicode

Comment 2 Daniel Engberg freebsd_committer

2022-01-07 20:54:51 UTC

Same issue have been reported before, https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=259732

Reference for https only, http://www.unicode.org/reports/tr44/#UCD_Files
Reference for UNIHAN, https://www.unicode.org/reports/tr38/

Comment 3 commit-hook freebsd_committer

2022-01-08 16:27:58 UTC

A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ae1444fdea5a04915a2983eb8b997ffa9a9bead2

commit ae1444fdea5a04915a2983eb8b997ffa9a9bead2
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2022-01-08 16:21:11 +0000
Commit:     Thierry Thomas <thierry@FreeBSD.org>
CommitDate: 2022-01-08 16:21:11 +0000

    textproc/UCD: fix fetch

    Patch proposed by Daniel Engberg <diizzy@FreeBSD.org>:
    - Only use HTTPS
    - Instead of creating a new directory for each release use a subdir
    - Grab license file from Unicode Han Database (Unihan) as they share the
      same and are both part of Unicode.

    PR:             260986
    Reported by:    jbeich

 textproc/UCD/Makefile | 11 +++++------
 textproc/UCD/distinfo | 14 +++++++-------
 2 files changed, 12 insertions(+), 13 deletions(-)

Comment 4 Thierry Thomas freebsd_committer

2022-01-08 16:29:18 UTC

Committed, thanks!

Comment 5 commit-hook freebsd_committer

2022-01-08 16:36:00 UTC

A commit in branch 2022Q1 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ed44725519c161b80225ff005282c5edb3fe5bed

commit ed44725519c161b80225ff005282c5edb3fe5bed
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2022-01-08 16:21:11 +0000
Commit:     Thierry Thomas <thierry@FreeBSD.org>
CommitDate: 2022-01-08 16:34:03 +0000

    textproc/UCD: fix fetch

    Patch proposed by Daniel Engberg <diizzy@FreeBSD.org>:
    - Only use HTTPS
    - Instead of creating a new directory for each release use a subdir
    - Grab license file from Unicode Han Database (Unihan) as they share the
      same and are both part of Unicode.

    PR:             260986
    Reported by:    jbeich

    (cherry picked from commit ae1444fdea5a04915a2983eb8b997ffa9a9bead2)

 textproc/UCD/Makefile | 11 +++++------
 textproc/UCD/distinfo | 14 +++++++-------
 2 files changed, 12 insertions(+), 13 deletions(-)