Bug 261094

Summary: net/babeld: not picking up the configuration file
Product: Ports & Packages Reporter: Dennis Noordsij <dennis.noordsij>
Component: Individual Port(s)Assignee: Li-Wen Hsu <lwhsu>
Status: Closed FIXED    
Severity: Affects Many People CC: gaod, lwhsu
Priority: --- Flags: gaod: maintainer-feedback+
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
babeld.patch none

Description Dennis Noordsij 2022-01-10 21:07:58 UTC
Having just installed babeld, I wondered why it was not picking up my configuration file (for which it installs a sample) at /usr/local/etc/babeld.conf

Changing the initd script to read:

  command_args="-D -I /var/run/${name}.pid -c $babeld_config"

instead of

  command_args="-D -I /var/run/${name}.pid $babeld_config"

fixes this and causes my config file to be read.

man babeld:
       -c filename
              Specify the name of the configuration file.  This flag can be
              repeated multiple times.  The default is /etc/babeld.conf.


(I don't know if this is on purpose as I'm not otherwise familiar with using babeld)
Comment 1 Hung-Yi Chen 2022-01-11 03:20:30 UTC
Created attachment 230894 [details]
babeld.patch
Comment 2 Hung-Yi Chen 2022-01-11 03:20:45 UTC
Hello Dennis,

You are so right. I thkni it's a bug. Thank you for the feedback.
I've attached a patch.
Comment 3 commit-hook freebsd_committer freebsd_triage 2022-01-11 09:31:01 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=9a61a97a87137ff512692f96aa93d5a3b1cfa8df

commit 9a61a97a87137ff512692f96aa93d5a3b1cfa8df
Author:     Hung-Yi Chen <gaod@hychen.org>
AuthorDate: 2022-01-11 09:28:09 +0000
Commit:     Li-Wen Hsu <lwhsu@FreeBSD.org>
CommitDate: 2022-01-11 09:30:07 +0000

    net/babeld: Fix rc script to pass config file correctly

    While here, update WWW

    PR:             261094
    Reported by:    Dennis Noordsij <dennis.noordsij@alumni.helsinki.fi>

 net/babeld/Makefile        | 1 +
 net/babeld/files/babeld.in | 3 +--
 net/babeld/pkg-descr       | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
Comment 4 commit-hook freebsd_committer freebsd_triage 2022-01-11 09:32:02 UTC
A commit in branch 2022Q1 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=a3f5513ce25ce2ad9576ac4e996fe960f32f482d

commit a3f5513ce25ce2ad9576ac4e996fe960f32f482d
Author:     Hung-Yi Chen <gaod@hychen.org>
AuthorDate: 2022-01-11 09:28:09 +0000
Commit:     Li-Wen Hsu <lwhsu@FreeBSD.org>
CommitDate: 2022-01-11 09:31:10 +0000

    net/babeld: Fix rc script to pass config file correctly

    While here, update WWW

    PR:             261094
    Reported by:    Dennis Noordsij <dennis.noordsij@alumni.helsinki.fi>

    (cherry picked from commit 9a61a97a87137ff512692f96aa93d5a3b1cfa8df)

 net/babeld/Makefile        | 1 +
 net/babeld/files/babeld.in | 3 +--
 net/babeld/pkg-descr       | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)