Bug 261189

Summary: www/elinks: Update to 0.15.0
Product: Ports & Packages Reporter: Dustin Marquess <jailbird>
Component: Individual Port(s)Assignee: Beat Gaetzi <beat>
Status: Closed FIXED    
Severity: Affects Many People CC: jcfyecrayz
Priority: --- Flags: bugzilla: maintainer-feedback? (beat)
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Update patch
none
FreeBSD 12/13 build fix none

Description Dustin Marquess 2022-01-14 03:20:42 UTC 
It appears that the fork that used to be called felinks got permission from the original ELinks offer to rename to back to elinks:

https://github.com/rkd77/elinks/commit/3db1abc5b7f09afcf41b27684af7a8d0d58eb7b3

Given that blessing and the fact that the old elinks is now over 9 years old, this patch updates elinks to the what-used-to-be-elinks version.  Hopefully this is acceptable.
Comment 1 Dustin Marquess 2022-01-14 03:20:59 UTC 
Created attachment 230996 [details]
Update patch
Comment 2 Beat Gaetzi freebsd_committer freebsd_triage 2022-01-29 15:44:45 UTC 
Thank you very much for your patch! Were you able to test your patch in poudriere?
Build fails here on FreeBSD 13.0 amd64 but it might also be related to my setup.
Comment 3 Dustin Marquess 2022-02-01 00:58:35 UTC 
It builds cleanly for me on HardenedBSD 14-CURRENT on amd64:

[00:16:04] [01] [00:01:17] Finished www/elinks | elinks-0.15.0: Success

I'll try building a 13-STABLE jail and test it in there.
Comment 4 Beat Gaetzi freebsd_committer freebsd_triage 2022-02-01 06:18:00 UTC 
Created attachment 231486 [details]
FreeBSD 12/13 build fix
Comment 5 Beat Gaetzi freebsd_committer freebsd_triage 2022-02-01 06:18:44 UTC 
Thank you very much! If it fails could you please try my patch and check if it works for you as well?
Comment 6 Beat Gaetzi freebsd_committer freebsd_triage 2022-02-01 06:28:47 UTC 
By the way: Would you like to take over the maintainership of elinks?
Comment 7 Dustin Marquess 2022-02-08 02:03:11 UTC 
Weird, I tried 12-STABLE, 13-STABLE, and 14-CURRENT, and I couldn't get it to fail on any of them. However, I still like your patch and I don't see any reason to not include it!

I'm perfectly willing to take over if you prefer. I can update the patch with a MAINTAINER change, if you want.
Comment 8 commit-hook freebsd_committer freebsd_triage 2022-02-16 07:05:30 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=2c3725f53ba571747a332fbab3a884b134c28280

commit 2c3725f53ba571747a332fbab3a884b134c28280
Author:     Dustin Marquess <jailbird@fdf.net>
AuthorDate: 2022-02-16 06:53:47 +0000
Commit:     Beat Gaetzi <beat@FreeBSD.org>
CommitDate: 2022-02-16 07:04:47 +0000

    www/elinks: Update to 0.15.0

    Pass maintainership to submitter

    PR:     261189

 www/elinks/Makefile                                 | 12 +++++++-----
 www/elinks/distinfo                                 |  5 +++--
 www/elinks/files/patch-configure.ac (new)           | 11 +++++++++++
 www/elinks/files/patch-src_intl_gettext_Makefile    |  8 ++++----
 .../files/patch-src_network_ssl_socket.c (gone)     | 20 --------------------
 www/elinks/files/patch-src_network_ssl_ssl.c (gone) | 21 ---------------------
 www/elinks/files/patch-src_osdep_unix_bsd.c (new)   | 13 +++++++++++++
 www/elinks/files/patch-src_scripting_lua_Makefile   |  4 ++--
 www/elinks/pkg-descr                                |  2 +-
 www/elinks/pkg-plist                                |  2 ++
 10 files changed, 43 insertions(+), 55 deletions(-)
Comment 9 Beat Gaetzi freebsd_committer freebsd_triage 2022-02-16 07:06:32 UTC 
I used RELEASE for my builds and if I'm recall correctly there was a header change in STABLE somewhere.

Committed the patch with you as the new maintainer.

Thank you very much for your work!
Comment 10 John Hein 2022-04-13 15:02:07 UTC 
www/elinks now fails if the SPIDERMONKEY option is on.
Comment 11 Dustin Marquess 2022-04-14 06:18:00 UTC 
(In reply to John Hein from comment #10)

Thanks for catching that, I'll see what's going on.
Comment 12 Dustin Marquess 2022-04-18 05:54:17 UTC 
(In reply to John Hein from comment #10)

So I can't reproduce this in a x86-64 14-CURRENT poudriere run.

Could you please file this as a new bug and let me know which OS version and arch you're on? Job output would help too.

Thanks!