Bug 261190

Summary: databases/py-ormar: Loosen sqlalchemy version
Product: Ports & Packages Reporter: Goran Mekić <meka>
Component: Individual Port(s)Assignee: Hiroki Tagato <tagattie>
Status: Closed FIXED    
Severity: Affects Only Me CC: meka, python, tagattie
Priority: --- Keywords: needs-qa
Version: LatestFlags: meka: maintainer-feedback+
Hardware: Any   
OS: Any   
Bug Depends on:    
Bug Blocks: 257369    
Attachments:
Description Flags
ormar.diff
none
ormar.diff
meka: maintainer-approval+
ormar.diff meka: maintainer-approval+

Description Goran Mekić 2022-01-14 08:14:13 UTC
Created attachment 230997 [details]
ormar.diff

With the current version specified, every time there's a sqlalchemy update, this port will fall out.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2022-01-14 23:35:32 UTC
What is the version specifier in the sources? If they also pin a max version, those also need to be patched, otherwise will result in a run time error
Comment 2 Goran Mekić 2022-01-24 18:08:31 UTC
In https://github.com/collerek/ormar/blob/master/pyproject.toml#L47 they are a bit too specific with the version, in my opinion.

As to pinning, I'm not sure what it means in terms of running the code. I mean, won't ormar use sqlalchemy that if finds?
Comment 3 Goran Mekić 2022-01-24 18:09:11 UTC
Created attachment 231281 [details]
ormar.diff

New version came out in the mean time.
Comment 4 Goran Mekić 2022-01-25 08:48:28 UTC
Created attachment 231302 [details]
ormar.diff

Same problem with databases/py-databases: version is pinned to the last digit of the version, hence fallout.
Comment 5 commit-hook freebsd_committer freebsd_triage 2022-01-29 06:32:15 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=919fa2a44a3191808598b5b8bdcfac65ce96ec8f

commit 919fa2a44a3191808598b5b8bdcfac65ce96ec8f
Author:     Goran Mekić <meka@tilda.center>
AuthorDate: 2022-01-29 06:28:48 +0000
Commit:     Hiroki Tagato <tagattie@FreeBSD.org>
CommitDate: 2022-01-29 06:31:24 +0000

    databases/py-ormar: update to 0.10.24

    While here, loosen version ranges of some dependencies to avoid build
    error.

    PR:             261190
    Reported by:    Goran Mekić <meka@tilda.center> (maintainer)
    Reviewed by:    koobs

 databases/py-ormar/Makefile | 6 +++---
 databases/py-ormar/distinfo | 6 +++---
 2 files changed, 6 insertions(+), 6 deletions(-)
Comment 6 Hiroki Tagato freebsd_committer freebsd_triage 2022-01-29 06:34:31 UTC
Committed, thanks!