Bug 261249

Summary: graphics/gmt: Use upstream release archive and remove fftw3 dependency
Product: Ports & Packages Reporter: Daniel Engberg <diizzy>
Component: Individual Port(s)Assignee: Loïc Bartoletti <lbartoletti>
Status: Closed FIXED    
Severity: Affects Only Me CC: diizzy
Priority: --- Flags: lbartoletti: maintainer-feedback+
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Patch for gmt none

Description Daniel Engberg freebsd_committer freebsd_triage 2022-01-16 16:32:54 UTC
Created attachment 231043 [details]
Patch for gmt

Using upstream release archive as suggested by Porters Handbook, this also reduces download size considerably
Remove fftw3 dependency, gmt depends on a legacy version of fftw3

Compile tested on FreeBSD 13.0-STABLE #2 stable/13-n248607-93a95ebbf7c (amd64) (make, make check-plist)
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2022-01-16 16:33:41 UTC
References:
https://git.ligo.org/lscsoft/lalsuite/-/issues/26
http://www.fftw.org/fftw3_doc/Wisdom-Import.html

...
-- Looking for fftwf_plan_with_nthreads in /usr/local/lib/libfftw3f.so
-- Looking for fftwf_plan_with_nthreads in /usr/local/lib/libfftw3f.so - not found
-- Looking for fftwf_import_wisdom_from_filename
-- Looking for fftwf_import_wisdom_from_filename - not found
CMake Warning at cmake/modules/FindFFTW3.cmake:90 (message):
  FFTW library found, but it is either too old (<3.3) or statically-linked.
Call Stack (most recent call first):
  src/CMakeLists.txt:201 (find_package)
...

We might want also to enable OpenMP support on amd64 and aarch64?
Comment 2 Loïc Bartoletti freebsd_committer freebsd_triage 2022-01-17 19:14:23 UTC
(In reply to Daniel Engberg from comment #1)
> We might want also to enable OpenMP support on amd64 and aarch64?

Yes, please.

You can commit it.
Comment 3 commit-hook freebsd_committer freebsd_triage 2022-01-19 07:52:59 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=c8a161f93f570e9fa86c393dae11051525e92069

commit c8a161f93f570e9fa86c393dae11051525e92069
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2022-01-19 07:31:45 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2022-01-19 07:52:05 +0000

    graphics/gmt: Use upstream release archive and remove fftw3 dependency

    Using upstream release archive as suggested by Porters Handbook,
    this also reduces download size considerably
    Remove fftw3 dependency, gmt depends on a legacy version of fftw3
    Remove unnecessary variables in CMAKE_ARGS

    PR:             261249
    Reviewed by:    lbartoletti@ (maintainer)

 graphics/gmt/Makefile | 12 +++++-------
 graphics/gmt/distinfo |  6 +++---
 2 files changed, 8 insertions(+), 10 deletions(-)
Comment 4 Daniel Engberg freebsd_committer freebsd_triage 2022-01-19 08:25:40 UTC
I'll add OpenMP in a separate commit