Bug 261262
| Summary: | math/glm: Use upstream release archive | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Daniel Engberg <diizzy> | ||||
| Component: | Individual Port(s) | Assignee: | Dmitry Marakasov <amdmi3> | ||||
| Status: | Closed Not Accepted | ||||||
| Severity: | Affects Only Me | Flags: | bugzilla:
maintainer-feedback?
(amdmi3) |
||||
| Priority: | --- | ||||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
I will not accept that, sorry. GitHub snapshots should always be preferred - for consistency (standardized subdir, endline style, known commit) - for uniformity with ports which do not have tarballs - for being clean of generated files or accidental binaries - for the ease of switching a port to a different commit (such as for debugging, testing latest code or pulling upstream fixes after the release) - for the ease of using a real git checkout in wrkdir, for debugging and upstreaming port changes This is a great example of why generated tarballs should be discouraged when VCS snapshot is available: using a tarball required fixing two things in it, in addition to pulling an extra dependency. |
Created attachment 231064 [details] Patch for glm Use upstream release archive as recommended by Porters Handbook (USE_GITHUB section) Compile tested on FreeBSD 13.0-STABLE #2 stable/13-n248607-93a95ebbf7c (amd64) (make, make check-plist)