Bug 261370

Summary: "Book menu" fades but does not appear when clicked on mobile breakpoints
Product: Documentation Reporter: Graham Perrin <grahamperrin>
Component: Books & ArticlesAssignee: Sergio Carlavilla Delgado <carlavilla>
Status: Closed FIXED    
Severity: Affects Some People CC: carlavilla
Priority: --- Keywords: accessibility, needs-qa, regression
Version: Latest   
Hardware: Any   
OS: Any   
URL: https://docs.freebsd.org/en/books/faq/
See Also: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=261371
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=261372
Attachments:
Description Flags
screenshot: Book menu not visible when clicked on mobile breakpoints none

Description Graham Perrin freebsd_committer freebsd_triage 2022-01-21 02:56:06 UTC 
1. At books such as <https://docs.freebsd.org/en/books/dev-model/> or 
   <https://docs.freebsd.org/en/books/faq/>

2. narrow the page until the Book menu button appears

3. click the button

Expected: 

4. a menu

Actual result: 

4. no menu

5. content fades
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2022-01-21 03:01:50 UTC 
@Graham Are you able to isolate a commit that introduced the issue?
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2022-01-21 03:02:27 UTC 
Created attachment 231202 [details]
screenshot: Book menu not visible when clicked on mobile breakpoints
Comment 3 Graham Perrin freebsd_committer freebsd_triage 2022-01-21 06:03:50 UTC 
(In reply to Kubilay Kocak from comment #1)

I'll try to find it, maybe at the weekend.
Comment 4 Sergio Carlavilla Delgado freebsd_committer freebsd_triage 2022-02-28 18:15:01 UTC 
Really good catch!
I'll fix it, it's easy :)
Comment 5 commit-hook freebsd_committer freebsd_triage 2022-02-28 19:04:02 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/doc/commit/?id=96597816b4c714683dda2767b14fb44f9d48431b

commit 96597816b4c714683dda2767b14fb44f9d48431b
Author:     Sergio Carlavilla Delgado <carlavilla@FreeBSD.org>
AuthorDate: 2022-02-28 19:01:36 +0000
Commit:     Sergio Carlavilla Delgado <carlavilla@FreeBSD.org>
CommitDate: 2022-02-28 19:01:36 +0000

    Remove mobile book menu in books without menu

    PR:             261370
    Submitted by:   Graham Perrin <grahamperrin (AT) gmail.com>

 documentation/themes/beastie/assets/styles/documentation.scss | 11 +++++++----
 documentation/themes/beastie/layouts/books/list.html          |  2 ++
 documentation/themes/beastie/layouts/books/single.html        |  2 ++
 3 files changed, 11 insertions(+), 4 deletions(-)
Comment 6 Sergio Carlavilla Delgado freebsd_committer freebsd_triage 2022-02-28 19:05:25 UTC 
Fixed!