Bug 261378
| Summary: | Tools/scripts/addport: Switch to git (still uses svn or svnlite) | ||
|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Pau Amma <pauamma> |
| Component: | Ports Framework | Assignee: | Port Management Team <portmgr> |
| Status: | Closed Overcome By Events | ||
| Severity: | Affects Some People | CC: | crees, devnull, pizzamig, ports-bugs, rene |
| Priority: | --- | Keywords: | needs-patch |
| Version: | Latest | Flags: | crees:
maintainer-feedback+
koobs: merge-quarterly? |
| Hardware: | Any | ||
| OS: | Any | ||
|
Description
Pau Amma
2022-01-21 14:50:03 UTC
I'm not against either, but I don't have the time to do so I'm afraid. Anyone is free to grab this (and perhaps take maintainership too!) If I remember correctly the (inoffical) concensus within portmgr at the time was that addport felt artifical/superfluous with the git workflow. Converting it to git might be more than s/svnlite/git though. (In reply to Rene Ladan from comment #2) Superfluous enough to deprecate it officially starting with a note in section 22 of the Committer's Guide and appropriate language in addport itself? (In reply to PauAmma from comment #3) See https://reviews.freebsd.org/D35071 And https://reviews.freebsd.org/D35104 for removing addport itself. And https://reviews.freebsd.org/D35104 for removing addport itself. Absolutely agree that it's time for addport to go. I don't really see a way to shoehorn git in in a way that is going to robustly avoid, for example, unwanted pushes. It also uses partial checkouts, which git doesn't support in the same way. The Committer's Guide has been updated to remove addport and to provide guidance on how to add a new port with git https://cgit.freebsd.org/doc/commit/?id=e1f62cbb8da6f1f70013559d83d76d1458d39ce7 addport has been removed in this commit. https://cgit.freebsd.org/ports/commit/Tools/scripts?id=bec21c95d998ff28ef8a8337cec3b9fce8074ce8 This PR can be closed now |
