Bug 261416
| Summary: | multimedia/pipewire: Add PIPEWIRE_JACK option | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Yuri Victorovich <yuri> | ||||||
| Component: | Individual Port(s) | Assignee: | Gleb Popov <arrowd> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Only Me | Flags: | arrowd:
maintainer-feedback+
|
||||||
| Priority: | --- | ||||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
Created attachment 231252 [details]
patch
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=8d5ab482f0a609d5e62719c3bc97c72d2b113d44 commit 8d5ab482f0a609d5e62719c3bc97c72d2b113d44 Author: Gleb Popov <arrowd@FreeBSD.org> AuthorDate: 2022-01-26 07:57:09 +0000 Commit: Gleb Popov <arrowd@FreeBSD.org> CommitDate: 2022-01-26 07:58:04 +0000 multimedia/pipewire: Remove the usage of bsd.port.options.mk PR: 261416 multimedia/pipewire/Makefile | 6 ------ multimedia/pipewire/pkg-plist | 1 + 2 files changed, 1 insertion(+), 6 deletions(-) A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=37077982c4c244cddcb8afa5a3919bc32ff4e422 commit 37077982c4c244cddcb8afa5a3919bc32ff4e422 Author: Yuri Victorovich <yuri@freebsd.org> AuthorDate: 2022-01-26 07:50:43 +0000 Commit: Gleb Popov <arrowd@FreeBSD.org> CommitDate: 2022-01-26 07:58:04 +0000 multimedia/pipewire: Add PIPEWIRE_JACK option. PR: 261416 multimedia/pipewire/Makefile | 18 ++++++++++++++---- multimedia/pipewire/pkg-plist | 10 ++++++++++ 2 files changed, 24 insertions(+), 4 deletions(-) The patch you provided was a bit strange - it had conflicting changes for pkg-plist. Pushed in anyways, thanks! |
Created attachment 231251 [details] patch The attached patch adds option PIPEWIRE_JACK that enables the corresponding project option to install Jack support. libjack.so is intentionally not added to USE_LDCONFIG, because I am planning to add general pipewire-jack support. This would add DEFAULT_VERSIONS+=jack={jack2,pipewire-jack}, USES=jack, and the port audio/jack-proxy. The latter port would depend on either audio/jack or multimedia/pipewire depending on jack choice in DEFAULT_VERSIONS, and it would have the relevant USE_LDCONFIG choice. The current patch just installs the pipewire-jack files.