Bug 261465
| Summary: | net-p2p/prowlarr: Dont chown prowlarr binaries on daemon start | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Michiel van Baak Jansen <michiel> | ||||||||
| Component: | Individual Port(s) | Assignee: | Fernando Apesteguía <fernape> | ||||||||
| Status: | Closed FIXED | ||||||||||
| Severity: | Affects Some People | CC: | fernape | ||||||||
| Priority: | --- | ||||||||||
| Version: | Latest | ||||||||||
| Hardware: | Any | ||||||||||
| OS: | Any | ||||||||||
| Attachments: |
|
||||||||||
Created attachment 231318 [details]
0001-net-p2p-prowlarr-Dont-chown-prowlarr-binaries-tell-u.patch
Created attachment 231319 [details]
0001-net-p2p-prowlarr-Dont-chown-prowlarr-binaries-tell-u.patch
Hi Michiel, Thanks for the patch. However, it seems to do more than just avoiding changing permissions. It also removes files (dll mainly), and do some cleaning. What is a good abstract for this patch? (In reply to Fernando Apesteguía from comment #3) After talking to the sonarr devs (codebase of prowlarr is based on it) they pointed out that the Prowlarr.Update directory and its contents should be removed when packaging up the code. The module in there is ran AFTER prowlarr built-in updater updated a new version from github and unpacked it in TEMPDIR. But, it uses the module inside the unpacked code in TEMPDIR. So basically the one shipped in the DISTFILE is outdated and not needed. debian packages and docker images have this directory removed as well, so I added the rm as well. so maybe somethnig like tthis: Cleanup package content and do not run chown on the prowlarr binaries Sorry for not being clear in the first place. Thanks for pointing that out. Same cleanup can also be found here for sonarr: https://bugs.freebsd.org/bugzilla/attachment.cgi?id=231317&action=diff Also both this patch and the sonarr one: poudriere ok runtest ok Runs in production (13.0-amd64) Committed, Thanks! A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=cc7a787d5f043014dcea80bd0058dd7117a5e308 commit cc7a787d5f043014dcea80bd0058dd7117a5e308 Author: Michiel van Baak Jansen <michiel@vanbaak.eu> AuthorDate: 2022-01-26 12:56:49 +0000 Commit: Fernando Apesteguía <fernape@FreeBSD.org> CommitDate: 2022-01-27 06:50:34 +0000 net-p2p/prowlarr: port clean up * Cleanup package content * Do not run chown on the prowlarr binaries PR: 261465 Reported by: michiel@vanbaak.eu (maintainer) net-p2p/prowlarr/Makefile | 7 +- net-p2p/prowlarr/files/package_info.in | 2 +- net-p2p/prowlarr/files/pkg-message.in | 3 +- net-p2p/prowlarr/files/prowlarr.in | 3 - net-p2p/prowlarr/pkg-plist | 233 --------------------------------- 5 files changed, 8 insertions(+), 240 deletions(-) |
Created attachment 231310 [details] 0001-net-p2p-prowlarr-Dont-chown-prowlarr-binaries-tell-u.patch