Bug 261710

Summary: www/firefox: explicitly depend on xtst to fix build with PULSEAUDIO=off
Product: Ports & Packages Reporter: Benjamin Takacs <nimaje+fbz>
Component: Individual Port(s)Assignee: Christoph Moench-Tegeder <cmt>
Status: Closed FIXED    
Severity: Affects Only Me CC: cmt, gecko
Priority: --- Flags: bugzilla: maintainer-feedback? (gecko)
nimaje+fbz: merge-quarterly?
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
www/firefox: explicitly depend on xtst to fix build with PULSEAUDIO=off nimaje+fbz: maintainer-approval? (gecko)

Description Benjamin Takacs 2022-02-04 11:54:52 UTC 
Created attachment 231552 [details]
www/firefox: explicitly depend on xtst to fix build with PULSEAUDIO=off

Since version 96.0 firefox lists xtst as recommended[0].

Trying to build www/firefox version 97.0_1,2 with PULSEAUDIO=off fails in configure because it can't find xtst.

The default options pull in xtst via pulseaudio.

Requesting merge-quarterly as version 96.0.3 on quarterly is probably affected too and needs this build fix

QA:
poudriere: builds (12.2-R, amd64, (CANBERRA=off DBUS=off DEBUG=off FFMPEG=off LIBPROXY=off LTO=on OPTIMIZED_CFLAGS=on PROFILE=on TESTS=off ALSA=off JACK=off PULSEAUDIO=off SNDIO=on))

[0]: https://www.mozilla.org/en-US/firefox/96.0/system-requirements/
Comment 1 commit-hook freebsd_committer freebsd_triage 2022-02-05 00:37:00 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=da0c0814149389ee67b37d6dabd791f65058b84a

commit da0c0814149389ee67b37d6dabd791f65058b84a
Author:     Christoph Moench-Tegeder <cmt@FreeBSD.org>
AuthorDate: 2022-02-04 22:56:24 +0000
Commit:     Christoph Moench-Tegeder <cmt@FreeBSD.org>
CommitDate: 2022-02-05 00:36:10 +0000

    www/firefox: depends on libXtst for the new libwebrtc

    the current libwebrtc needs libXtst - even as firefox' docs only
    "recommend" libXtst, it's actually a hard requirement.
    this goes into bsd.gecko.mk, as it will affect all gecko ports in
    due time, even if currently only www/firefox has the new libwebrtc.

    PR:             261710
    Reported by:    Benjamin Takacs

 Mk/bsd.gecko.mk      | 2 +-
 www/firefox/Makefile | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Comment 2 commit-hook freebsd_committer freebsd_triage 2022-02-05 00:40:01 UTC 
A commit in branch 2022Q1 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=a7c4afef1154200f55932a6edbaeb40136a84aa2

commit a7c4afef1154200f55932a6edbaeb40136a84aa2
Author:     Christoph Moench-Tegeder <cmt@FreeBSD.org>
AuthorDate: 2022-02-04 22:56:24 +0000
Commit:     Christoph Moench-Tegeder <cmt@FreeBSD.org>
CommitDate: 2022-02-05 00:39:33 +0000

    www/firefox: depends on libXtst for the new libwebrtc

    the current libwebrtc needs libXtst - even as firefox' docs only
    "recommend" libXtst, it's actually a hard requirement.
    this goes into bsd.gecko.mk, as it will affect all gecko ports in
    due time, even if currently only www/firefox has the new libwebrtc.

    PR:             261710
    Reported by:    Benjamin Takacs

    (cherry picked from commit da0c0814149389ee67b37d6dabd791f65058b84a)

 Mk/bsd.gecko.mk      | 2 +-
 www/firefox/Makefile | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Comment 3 Christoph Moench-Tegeder freebsd_committer freebsd_triage 2022-02-05 00:41:10 UTC 
ah, webrtc. committed, thanks.