Summary: | sysutils/rundeck3: Fix no logging. Use daemon(8) for logging | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | ruben | ||||||
Component: | Individual Port(s) | Assignee: | Robert Clausecker <fuz> | ||||||
Status: | Closed FIXED | ||||||||
Severity: | Affects Many People | CC: | daniel.tihanyi, fuz | ||||||
Priority: | --- | Keywords: | needs-qa | ||||||
Version: | Latest | Flags: | daniel.tihanyi:
maintainer-feedback+
koobs: merge-quarterly? |
||||||
Hardware: | Any | ||||||||
OS: | Any | ||||||||
Attachments: |
|
Hi! Thank you for the patch, unfortunately I cannot test it right now, but I should be able to do it in the next couple of weeks. Also I think there is an update for Rundeck, so I might also include that. Created attachment 231916 [details]
Extending previous patch with Rundeck 3.4.10 update, as well as small fix
Hi!
Thank you for the patch, there was a quote missing in the line "command_args", but I added that and now it works flawlessly.
I also added a small change to update Rundeck to version 3.4.10.
Is there a changelog for Rundeck 3.4.10 which I can use for the commit message? If not, please summarise the changes at least. When committing, I'll remove the conditional code as it no longer applies to any supported FreeBSD version. (In reply to Robert Clausecker from comment #4) Agree, the pre 12.3 support is pretty moot now. for what it is worth, this is a link to the Rundeck release notes https://docs.rundeck.com/docs/history/3_4_x/version-3.4.10.html#overview Uh this fixes CVE-2021-44832. Will have to update VUXML probably. (In reply to Robert Clausecker from comment #6) Could you please also remove me as Maintainer? Unfortunately I don't have the capacity to continue to maintain Rundeck for FreeBSD. It's pretty straightforward though, so easy for someone to pick up. The old Rundeck version (sysutils/rundeck2) should be removed also as that's old and unmaintained. Thank you very much! (In reply to Daniel Tihanyi from comment #7) I'll drop your maintainership from sysutils/rundeck2 and sysutils/rundeck3. I'm sorry that nobody has processed your PR in such a long time. Do you have any other issues you wish to have addressed? (In reply to Robert Clausecker from comment #8) Don't worry about it, I anyway had no time for this. :-) There is nothing else from me, thank you very much! A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=31b0c7cc1e13a427686091324534a59738f54712 commit 31b0c7cc1e13a427686091324534a59738f54712 Author: Robert Clausecker <fuz@FreeBSD.org> AuthorDate: 2023-02-16 09:45:40 +0000 Commit: Robert Clausecker <fuz@FreeBSD.org> CommitDate: 2023-02-19 11:01:41 +0000 security/vuxml: document log4j vulnerability in sysutils/rundeck3 PR: 261748 Reported by: ruben@verweg.com Approved by: flo (mentor) Differential Revision: https://reviews.freebsd.org/D38636 security/vuxml/vuln/2023.xml | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+) A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=df09fa81db51c5a68a948c7a7984d380a6460649 commit df09fa81db51c5a68a948c7a7984d380a6460649 Author: Ruben van Staveren <ruben@verweg.com> AuthorDate: 2023-02-15 13:34:40 +0000 Commit: Robert Clausecker <fuz@FreeBSD.org> CommitDate: 2023-02-19 11:01:40 +0000 sysutils/rundeck3: update to 3.4.10 - use logging facilities of daemon(8) to enable log rotation - simplify DISTNAME generation Changelog: https://docs.rundeck.com/docs/history/3_4_x/version-3.4.10.html MFH: 2023Q1 PR: 261748 Security: 27c822a0-addc-11ed-a9ee-dca632b19f10 Reported by: ruben@verweg.com Approved by: eduardo (mentor) Differential Revision: https://reviews.freebsd.org/D38634 sysutils/rundeck3/Makefile | 9 ++++----- sysutils/rundeck3/distinfo | 6 +++--- sysutils/rundeck3/files/rundeck.in | 2 +- 3 files changed, 8 insertions(+), 9 deletions(-) A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=e1d48f6437e25cdfc6a8df6fb4270b57eb5e5a2b commit e1d48f6437e25cdfc6a8df6fb4270b57eb5e5a2b Author: Robert Clausecker <fuz@FreeBSD.org> AuthorDate: 2023-02-16 10:24:58 +0000 Commit: Robert Clausecker <fuz@FreeBSD.org> CommitDate: 2023-02-19 11:01:41 +0000 sysutils/rundeck{2,3}: drop maintainership PR: 261748 Approved by: flo (mentor) Differential Revision: https://reviews.freebsd.org/D38635 sysutils/rundeck2/Makefile | 2 +- sysutils/rundeck3/Makefile | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) A commit in branch 2023Q1 references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=85e9f07dc4825233016c5be1c4b6f22be622c569 commit 85e9f07dc4825233016c5be1c4b6f22be622c569 Author: Ruben van Staveren <ruben@verweg.com> AuthorDate: 2023-02-15 13:34:40 +0000 Commit: Robert Clausecker <fuz@FreeBSD.org> CommitDate: 2023-02-19 11:03:21 +0000 sysutils/rundeck3: update to 3.4.10 - use logging facilities of daemon(8) to enable log rotation - simplify DISTNAME generation Changelog: https://docs.rundeck.com/docs/history/3_4_x/version-3.4.10.html MFH: 2023Q1 PR: 261748 Security: 27c822a0-addc-11ed-a9ee-dca632b19f10 Reported by: ruben@verweg.com Approved by: eduardo (mentor) Differential Revision: https://reviews.freebsd.org/D38634 (cherry picked from commit df09fa81db51c5a68a948c7a7984d380a6460649) sysutils/rundeck3/Makefile | 9 ++++----- sysutils/rundeck3/distinfo | 6 +++--- sysutils/rundeck3/files/rundeck.in | 2 +- 3 files changed, 8 insertions(+), 9 deletions(-) Thank you for your submission. |
Created attachment 231579 [details] [PATCH] Don't redirect to logfile, but have daemon manage it in a logrotate friendly manner Currently rundeck3 startup uses “ > ${rundeck_log_file}” but this doesn’t log anything at all. Better is to use daemon(8)’s -o flag. On 12.3+ -H is also added to make it newsyslog(1) friendly too