Bug 261778
| Summary: | games/nbsdgames: update to 5 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Robert Clausecker <fuz> | ||||
| Component: | Individual Port(s) | Assignee: | Fernando Apesteguía <fernape> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | fernape | ||||
| Priority: | --- | Keywords: | easy | ||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| URL: | https://github.com/abakh/nbsdgames/releases/tag/v5 | ||||||
| Attachments: |
|
||||||
====> Running Q/A tests (stage-qa) ====> Checking for pkg-plist issues (check-plist) ===> Parsing plist ===> Checking for items in STAGEDIR missing from pkg-plist Error: Orphaned: share/applications/nbsdgames.desktop Error: Orphaned: share/icons/hicolor/scalable/apps/nbsdgames.svg ===> Checking for items in pkg-plist which are not in STAGEDIR ===> Error: Plist issues found. *** Error code 1 ^Triage: Please confirm this change passes QA (portlint, poudriere at least) For details and instructions, see: https://docs.freebsd.org/en/books/porters-handbook/#testing No need to update a new patch. I'll fix it at commit time. (In reply to Fernando Apesteguía from comment #1) Hi, Thank you for catching this. I had forgotten to "git add" a last-minute change to distinfo. The change reads: diff --git a/games/nbsdgames/pkg-plist b/games/nbsdgames/pkg-plist index 3649e7008be1..528cdc899286 100644 --- a/games/nbsdgames/pkg-plist +++ b/games/nbsdgames/pkg-plist @@ -25,6 +25,8 @@ bin/sudoku @sample(,games,0664) /var/games/nbsdgames/miketron_scores.sample @sample(,games,0664) /var/games/nbsdgames/pipes_scores.sample @sample(,games,0664) /var/games/nbsdgames/tugow_scores.sample +share/applications/nbsdgames.desktop +share/icons/hicolor/scalable/apps/nbsdgames.svg share/man/man6/battleship.6.gz share/man/man6/checkers.6.gz share/man/man6/darrt.6.gz With this change, the patch passes QA on my machine. Committed, Thanks! A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=03c4407ac9801a6d5619036daa70ba71bca942f6 commit 03c4407ac9801a6d5619036daa70ba71bca942f6 Author: Robert Clausecker <fuz@fuz.su> AuthorDate: 2022-02-08 07:02:18 +0000 Commit: Fernando Apesteguía <fernape@FreeBSD.org> CommitDate: 2022-02-08 09:15:36 +0000 games/nbsdgames: update to 5 From ChangeLog: https://github.com/abakh/nbsdgames/releases/tag/v5 * icon and menu shortcut included * tugow added * menu added * sudoku algorithm is replaced with a simple and fast algorithm that generates good puzzles in little time * miketron gameplay is improved upon * RedSquare now fits in the screen * command-line options are now in more conventional, getopt syntax * minor bug fixes PR: 261778 Reported by: fuz@fuz.su (maintainer) games/nbsdgames/Makefile | 7 ++++++- games/nbsdgames/distinfo | 6 +++--- games/nbsdgames/files/patch-Makefile | 18 ++++++++++-------- games/nbsdgames/pkg-plist | 5 +++++ 4 files changed, 24 insertions(+), 12 deletions(-) |
Created attachment 231611 [details] games/nbsdgames: update to 5 Upstream changes: - icon and menu shortcut included - tugow added - menu added - sudoku algorithm is replaced with a simple and fast algorithm that generates good puzzles in little time - miketron gameplay is improved upon - RedSquare now fits in the screen - command-line options are now in more conventional, getopt syntax - minor bug fixes Tested with Poudriere on armv7 arm64 FreeBSD 13.