Bug 261903
| Summary: | lang/php8: libressl wrongly disabled | ||
|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Ivan Rozhuk <rozhuk.im> |
| Component: | Individual Port(s) | Assignee: | Muhammad Moinur Rahman <bofh> |
| Status: | Closed FIXED | ||
| Severity: | Affects Some People | CC: | ale, bofh, pi, portmgr, rozhuk.im, tz, vishwin |
| Priority: | --- | ||
| Version: | Latest | ||
| Hardware: | Any | ||
| OS: | Any | ||
(In reply to Ivan Rozhuk from comment #0) There are thousands of permutation and combination for the entire ports tree and it is not at all possible for us to check all the permutation and combinations. I have no problem in marking it to work with libressl but we do not have enough resources to test the usability of php with anything other than openssl atm. Before making changes I will need logs that it actually builds other extensions too. And as you have mentioned in your title; it's not at all "wrongly disabled". It's disabled on tests that I have done so far. http://pdr.bofh.network/build.html?mastername=130-default-libressl&build=2022-02-12_11h23m21s This is not PHP issue with libressl, this is curl in some configurations, PHP must not handle it. https://people.freebsd.org/~vishwin/2022-02-12_12h16m20s/build.html Most notably, arcanist has always worked, otherwise submitting phab reviews would be a bit more tedious. (In reply to Charlie Li from comment #4) What's in your ftp_curl_SET= and ftp_curl_UNSET= ? The only relevant option unset in ftp/curl is TLS_SRP. See https://cgit.freebsd.org/ports/tree/ftp/curl/Makefile#n146 (In reply to Charlie Li from comment #6) Thanks. Checking. Will need sometimes to revert back. My builder is overloaded. :( A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=b904062e277f750c3a12b9a8cd8af97c3230fbe4 commit b904062e277f750c3a12b9a8cd8af97c3230fbe4 Author: Muhammad Moinur Rahman <bofh@FreeBSD.org> AuthorDate: 2022-02-12 20:43:26 +0000 Commit: Muhammad Moinur Rahman <bofh@FreeBSD.org> CommitDate: 2022-02-12 20:46:51 +0000 lang/php8[01]: Unbreak with libressl* lang/php8[01] builds fine with libressl*. Reverting previous partial commit. Although it takes minor tweaking on unsetting TLS_SRP on ftp/curl. PR: 261903 Reported by: vishwin rozhuk.im@gmail.com Approved by: tz (private email) Sponsored by: Bounce Experts lang/php80/Makefile | 4 ---- lang/php81/Makefile | 4 ---- 2 files changed, 8 deletions(-) Thanks! |
> # Although php builds fine with libressl* but most of the php modules > # require curl which fails to build with libressl*. So do an early > # check and prevent php from being built with libressl* This is not correct. CURL can not build only in combination: OPENSSL+TLS_SRP, while openssl=libressl. .if ((!${PORT_OPTIONS:MGNUTLS} && !${PORT_OPTIONS:MOPENSSL}) || (${PORT_OPTIONS:MOPENSSL} && ${SSL_DEFAULT:Mlibressl*})) && ${PORT_OPTIONS:MTLS_SRP} IGNORE= only supports TLS-SRP with either OpenSSL or GnuTLS .endif User can unset TLS_SRP or use GnuTLS and same time have libressl for all other ports.