Bug 262019
| Summary: | math/igraph: Use upstream release archive, remove libtool, add LICENSE_FILE | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Daniel Engberg <diizzy> | ||||||
| Component: | Individual Port(s) | Assignee: | Wen Heping <wen> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Many People | CC: | wenheping2000 | ||||||
| Priority: | --- | Keywords: | needs-qa | ||||||
| Version: | Latest | Flags: | bugzilla:
maintainer-feedback?
(wen) koobs: merge-quarterly? |
||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
@Daniel Could you explain the why for libtool removal? Is it not used? No longer necessary with distfiles change? Also, LICENSE_FILES should be LICENSE_FILE? Created attachment 231907 [details]
Patch for igraph v2
Use correct variable name, LICENSE_FILES --> LICENSE_FILE
(In reply to Kubilay Kocak from comment #1) libtool isn't used at all, this requirement most likely changed when upstream switched to use CMake Thanks for pointing out my mistake about LICENSE_FILE Friendly ping (In reply to Daniel Engberg from comment #4) Sorry for the delay. I approve the patch, please go ahead ! Thank you ! wen A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=1df2fd6a40dd5f605eb2a6492c42ea1e641ca280 commit 1df2fd6a40dd5f605eb2a6492c42ea1e641ca280 Author: Daniel Engberg <diizzy@FreeBSD.org> AuthorDate: 2022-03-19 06:19:25 +0000 Commit: Daniel Engberg <diizzy@FreeBSD.org> CommitDate: 2022-03-19 06:19:29 +0000 math/igraph: Use upstream release archive - Define LICENSE_FILE - Remove libtool dependency - Use DISTVERSION to follow Porters Handbook more closely PR: 262019 Reviewed by: wen (maintainer) math/igraph/Makefile | 9 +++++---- math/igraph/distinfo | 6 +++--- 2 files changed, 8 insertions(+), 7 deletions(-) |
Created attachment 231901 [details] Patch for igraph Use upstream release archive as recommended by Porters Handbook (USE_GITHUB section) Remove libtool dependency Use DISTVERSION as recommended by Porters Handbook (3.1. Writing the Makefile and "Table 2. Package Naming Examples") Compiled tested on FreeBSD 13.0-STABLE #2 stable/13-n248607-93a95ebbf7c (amd64) (make, make check-plist)