Bug 262022

Summary: net-mgmt/nagiosql: Add DEPRECATED and fix for PHP 7.4
Product: Ports & Packages Reporter: Helmut Ritter <freebsd-ports>
Component: Individual Port(s)Assignee: Dan Langille <dvl>
Status: Closed Overcome By Events    
Severity: Affects Many People Keywords: needs-qa
Priority: --- Flags: dvl: maintainer-feedback+
koobs: merge-quarterly?
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Patch to add deprecation
none
Patch admin directory
none
Patch functions directory
none
Patch for PHP7.4
none
Poudriere Log none

Description Helmut Ritter 2022-02-17 19:53:17 UTC
Created attachment 231902 [details]
Patch to add deprecation

Attached a patch to add deprecation of nagiosql end of 2022 because it relies on PHP74. In addition 2 files for files/ to work with php7.4
Comment 1 Helmut Ritter 2022-02-17 19:55:23 UTC
Created attachment 231903 [details]
Patch admin directory

Please put in files/
Comment 2 Helmut Ritter 2022-02-17 19:56:26 UTC
Created attachment 231904 [details]
Patch functions directory

Please put in files/
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2022-02-17 21:40:23 UTC
@Reporter if you could generate a single patch against the latest version of the port using `make makepatch` that would be appreciated (please obsolete the existing attachments when uploading)
Comment 4 Helmut Ritter 2022-02-18 11:59:51 UTC
Sorry, I'm no expert, can you help me what I need to do?
Comment 5 Helmut Ritter 2022-02-18 12:06:22 UTC
(In reply to Helmut Ritter from comment #4)
 s/help/tell/
Comment 6 Dan Langille freebsd_committer freebsd_triage 2022-02-18 13:36:29 UTC
(In reply to Helmut Ritter from comment #5)

I think you are being asked to create a single patch and mark the other patches as obsolete.
Comment 7 Helmut Ritter 2022-02-18 14:29:41 UTC
(In reply to Dan Langille from comment #6)

Yes, but how? Can I just cat all pathches into a single file?
Comment 8 Dan Langille freebsd_committer freebsd_triage 2022-02-18 16:31:54 UTC
(In reply to Helmut Ritter from comment #7)
The proper way is git diff > patch-file

Does that help?
Comment 9 Helmut Ritter 2022-02-18 16:55:06 UTC
Created attachment 231921 [details]
Patch for PHP7.4
Comment 10 Helmut Ritter 2022-02-18 16:57:17 UTC
(In reply to Dan Langille from comment #8)

I tried with git diff a few times but wasn't successful. Attached a patch created via diff. I tested it on my productive system, no issues.
Comment 11 Helmut Ritter 2022-02-18 17:17:08 UTC
Created attachment 231922 [details]
Poudriere Log
Comment 12 Helmut Ritter 2022-04-04 08:05:19 UTC
Deprecated as of https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=262394, please close