Bug 262082

Summary: lang/urweb: Update to 20200209, Fix build on FreeBSD 12,13
Product: Ports & Packages Reporter: Timothy Beyer <beyert>
Component: Individual Port(s)Assignee: Muhammad Moinur Rahman <bofh>
Status: Closed FIXED    
Severity: Affects Many People CC: beyert, bofh, lwhsu
Priority: --- Keywords: needs-qa
Version: LatestFlags: beyert: maintainer-feedback+
koobs: merge-quarterly?
Hardware: Any   
OS: Any   
Bug Depends on: 261820    
Bug Blocks:    
Attachments:
Description Flags
[PATCH] update lang/urweb with latest version (20200209), fix build on FreeBSD 12,13, update LIB_DEPENDS, address portlint warnings
beyert: maintainer-approval+
[PATCH] update lang/urweb with latest version (20200209), build on poudriere, fix build on FreeBSD 12,13, update LIB_DEPENDS, address portlint warnings
beyert: maintainer-approval+
[PATCH] update lang/urweb with latest version (20200209), build on poudriere, fix build on FreeBSD 12,13, update LIB_DEPENDS, address portlint warnings beyert: maintainer-approval+

Description Timothy Beyer 2022-02-21 03:13:33 UTC 
This patch makes the following changes:

  *  Update lang/urweb to 20200209 (latest version)

  *  Unbreak port for modern FreeBSD versions, such as FreeBSD 12 and 13, and likely 14

  *  update LIB_DEPENDS with new dependencies (tested with empty build on FreeBSD 13 amd64 bhyve VM)

  *  address portlint warnings

I strongly recommend to apply the patch from PR #261820 "lang/mlton: Maintainer potential fix for build on FreeBSD 14, potential fix for i386 (all versions)", where I am also the maintainer, as this should resolve issues with building the build dependency mlton on i386 as well as FreeBSD 14:

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=261820
Comment 1 Timothy Beyer 2022-02-21 03:14:38 UTC 
Created attachment 231977 [details]
[PATCH] update lang/urweb with latest version (20200209), fix build  on FreeBSD 12,13, update LIB_DEPENDS, address portlint warnings
Comment 2 Li-Wen Hsu freebsd_committer freebsd_triage 2022-02-21 03:18:33 UTC 
*** Bug 262081 has been marked as a duplicate of this bug. ***
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2022-02-22 00:27:26 UTC 
@Maintainer What is the relationship between bug 261820 (mlton) and this issue (urweb), if any?
Comment 4 Timothy Beyer 2022-02-22 02:28:41 UTC 
(In reply to Kubilay Kocak from comment #3)

lang/urweb depends on lang/mlton for build, and as you can see on https://www.freshports.org/lang/mlton, the build servers are having issues building on i386 (which I suspect is due to out of control memory usage during the zone pass), which the patches to mlton should address.
Comment 5 Timothy Beyer 2022-05-17 04:23:40 UTC 
Created attachment 233981 [details]
[PATCH] update lang/urweb with latest version (20200209), build on poudriere, fix build on FreeBSD 12,13, update LIB_DEPENDS, address portlint warnings

As with my updated and corrected patch to lang/mlton, here is a revised patch that is built on poudriere in numerous configurations.

To clarify, I am the maintainer of both this port and lang/mlton.
Comment 6 Timothy Beyer 2022-05-17 04:50:55 UTC 
Created attachment 233986 [details]
[PATCH] update lang/urweb with latest version (20200209), build on poudriere, fix build on FreeBSD 12,13, update LIB_DEPENDS, address portlint warnings

fix subject in patch, but otherwise identical
Comment 7 Muhammad Moinur Rahman freebsd_committer freebsd_triage 2023-03-20 14:04:43 UTC 
As mentioned earlier taking this port as this is marked for deletion today.
Comment 8 commit-hook freebsd_committer freebsd_triage 2023-03-21 06:20:52 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ecae8fdb1f74efed8659989b9203961da8c3f1c1

commit ecae8fdb1f74efed8659989b9203961da8c3f1c1
Author:     Timothy Beyer <beyert@cs.ucr.edu>
AuthorDate: 2023-03-21 06:14:14 +0000
Commit:     Muhammad Moinur Rahman <bofh@FreeBSD.org>
CommitDate: 2023-03-21 06:19:54 +0000

    lang/urweb: Update version 20150520=>20200209

    - Unbreak port for modern FreeBSD versions, such as FreeBSD 12 and 13,
      and likely 14
    - Update LIB_DEPENDS with new dependencies
    - Pet portlint
    - While I(bofh) am here pet portclippy/portfmt
    - Utilize OPTIONSNG

    PR:             262082

 lang/urweb/Makefile                           | 78 +++++++++++----------------
 lang/urweb/distinfo                           |  5 +-
 lang/urweb/files/patch-src__c__urweb.c (gone) | 11 ----
 lang/urweb/pkg-plist                          | 24 +++++----
 4 files changed, 49 insertions(+), 69 deletions(-)
Comment 9 Muhammad Moinur Rahman freebsd_committer freebsd_triage 2023-03-21 06:21:36 UTC 
Please send git diffs from next time.