Bug 262135
| Summary: | databases/py-berkeleydb: Fix build when default version of berkeley db is 18 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Yasuhiro Kimura <yasu> | ||||||
| Component: | Individual Port(s) | Assignee: | Muhammad Moinur Rahman <bofh> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Some People | Keywords: | needs-qa | ||||||
| Priority: | --- | Flags: | bofh:
maintainer-feedback+
koobs: merge-quarterly- |
||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 261523 | ||||||||
| Attachments: |
|
||||||||
Side note, what a great build variable "YES_I_HAVE_THE_RIGHT_TO_USE_THIS_BERKELEY_DB_VERSION" :D Comment on attachment 232025 [details]
Patch file
Approved by: portmgr (blanket: build fix)
^Triage: MFH: No (BDB default will not change in quarterly) Sorry but this should be a conditional check like: if BDB_VERSION == 18 ; then MAKE_ENV= fi As long as 5 is in the tree. Once bdb5 is moved we can remove the conditionals. If you can resubmit the patch I will have a look again other wise I will check the exact syntax and update accordingly in the coming weekend. Created attachment 232096 [details]
Updated patch file
Set 'YES_I_HAVE_THE_RIGHT_TO_USE_THIS_BERKELEY_DB_VERSION=yes' only when ${BDB_VER} is larger than 5.
I was about to commit but I thought to give it a test. And I am not sure if I am missing something but I can't build this: I have DEFAULT_VERSIONS+= bdb=18 in BDB18-make.conf And why I am trying to build with: poudriere bulk -j MAIN -z BDB18 -p default -t databases/py-berkeleydb I am getting "cannot install: no eligible BerkeleyDB version. Requested: 18, incompatible: . Try: make debug-bdb" Even trying to build this port with USES=bdb:18 fails with the same error. Am I missing something here or is it that Uses/bdb.mk requires fixing? (In reply to Muhammad Moinur Rahman from comment #6) Currently you need to set 'WITH_BDB6_PERMITTED=yes' in make.conf to use db18 as default version of berkeley db. It's pitfall and will be removed when default version switches to 18. (In reply to Yasuhiro Kimura from comment #7) Ah okiz. Let me check one more time. Thanks for the pointer. A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=2214191eff6c1fd01ce14791f04077dcd16408da commit 2214191eff6c1fd01ce14791f04077dcd16408da Author: Yasuhiro Kimura <yasu@FreeBSD.org> AuthorDate: 2022-02-26 04:54:00 +0000 Commit: Muhammad Moinur Rahman <bofh@FreeBSD.org> CommitDate: 2022-02-26 04:54:00 +0000 databases/py-berkeleydb: Fix build with db18 PR: 262135 databases/py-berkeleydb/Makefile | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) |
Created attachment 232025 [details] Patch file Fix build when default version of berkeley db is 18.