Bug 262181

Summary: devel/py-coverage: Add databases/py-sqlite3 dependency
Product: Ports & Packages Reporter: Niclas <n_carlsson>
Component: Individual Port(s)Assignee: Li-Wen Hsu <lwhsu>
Status: Closed FIXED    
Severity: Affects Many People CC: lwhsu, python
Priority: --- Keywords: needs-qa
Version: Latest   
Hardware: Any   
OS: Any   
Bug Depends on:    
Bug Blocks: 262399    
Attachments:
Description Flags
Add py-sqlite3 dependency to py-coverage
none
Changed to DISTVERSION and bumped the PORTREVISION
none
Changed to DISTVERSION and bumped the PORTREVISION none

Description Niclas 2022-02-25 00:45:04 UTC 
Created attachment 232091 [details]
Add py-sqlite3 dependency to py-coverage

Since version 5.0 coverage uses SQLite instead of JSON:
https://github.com/nedbat/coveragepy/blob/a533780834c2223edb1e5db51457f53f677c1ac8/doc/whatsnew5x.rst

Since ports build Python without SQLite support this port should add databases/py-sqlite3 dependency as stated in ports Python pkg-message:

Note that some standard Python modules are provided as separate ports
as they require additional dependencies. They are available as:

py38-gdbm       databases/py-gdbm@py38
py38-sqlite3    databases/py-sqlite3@py38
py38-tkinter    x11-toolkits/py-tkinter@py38
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2022-02-25 00:50:32 UTC 
Thank you for the report and patch Niclas.

What is the current impact of the missing dependency, if any, and is it at build, run and/or test time?
Comment 2 Niclas 2022-02-25 15:13:32 UTC 
I noticed it while trying to run a test on a port that uses pytest-cov. It couldn't run because it couldn't find the sqlite3 module.
Comment 3 Niclas 2022-02-26 13:53:39 UTC 
Created attachment 232122 [details]
Changed to DISTVERSION and bumped the PORTREVISION

I made a new patch that changed from PORTVERSION to DISTVERSION as I understand that that is the preferred way and bumped the PORTREVISION to force an update.
Comment 4 Niclas 2022-02-27 07:02:25 UTC 
Created attachment 232131 [details]
Changed to DISTVERSION and bumped the PORTREVISION

Uploaded wrong file
Comment 5 Niclas 2022-03-26 23:33:43 UTC 
Apparently someone else fixed it without looking or mentioning it here.