Bug 262185
| Summary: | audio/darkice: Delete libaacplus | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | takefu | ||||||
| Component: | Individual Port(s) | Assignee: | Fernando Apesteguía <fernape> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Only Me | CC: | decke, fernape | ||||||
| Priority: | --- | Keywords: | needs-qa | ||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
Thank you for the report and patch - What is the rationale for AACPLUS removal? - Two options add libogg.so:audio/libogg as a dependency, what is the nature/why of this change? The CPE info does not exist in the CPE dictionary. It does not mean that it's wrong but do you have any confirmation that the CPE info is valid for this project? (like a previous CVE, some written statement etc.) Created attachment 232177 [details] darkice-1.4_2.patch2 (In reply to Kubilay Kocak from comment #1) % grep libaacplus /usr/ports/MOVED audio/libaacplus||2021-12-31|Has expired: Abandoned upstream, no new release since 2011 Audio/libogg The reason for addition is portlint(1) compliance. ====> Running Q/A tests (stage-qa) Error: /usr/local/bin/darkice is linked to /usr/local/lib/libogg.so.0 from audio/libogg but it is not declared as a dependency Warning: you need LIB_DEPENDS+=libogg.so:audio/libogg Error: /usr/local/bin/darkice is linked to /usr/local/lib/libsamplerate.so.0 from audio/libsamplerate but it is not declared as a dependency Warning: you need LIB_DEPENDS+=libsamplerate.so:audio/libsamplerate # cat /etc/make.conf DEVELOPER=1 (In reply to Bernhard Froehlich from comment #2) My mistake. LGTM. I'll commit this later today. Thank you all. A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=3341ddfca4f9e59fb86c6519045d4c94adb13c02 commit 3341ddfca4f9e59fb86c6519045d4c94adb13c02 Author: Kenji Takefu <takefu@airport.fm> AuthorDate: 2022-03-01 08:01:11 +0000 Commit: Fernando Apesteguía <fernape@FreeBSD.org> CommitDate: 2022-03-01 15:32:02 +0000 audio/darkice: Delete libaacplus * libaacplus has been abandoned * Add missing libogg dependency * Reporter becomes MAINTAINER PR: 262185 Reported by: takefu@airport.fm Reviewed by: decke@ koobs@ audio/darkice/Makefile | 31 +++++++++++++++++-------------- audio/darkice/files/darkice.in | 3 ++- audio/darkice/files/pkg-message.in | 12 +++--------- 3 files changed, 22 insertions(+), 24 deletions(-) Committed, Thanks! |
Created attachment 232095 [details] darkice-1.4_2.patch Add CPE information Delete audio/libaacplus Fix files/darkice.in files/pkg-message.in