Bug 262251

Summary: dns/py-aiodns: Update to 3.0.0
Product: Ports & Packages Reporter: Norikatsu Shigemura <nork>
Component: Individual Port(s)Assignee: freebsd-ports-bugs (Nobody) <ports-bugs>
Status: Closed FIXED    
Severity: Affects Some People CC: romain, waitman
Priority: --- Flags: nork: maintainer-feedback-
p5B2EA84B3: maintainer-feedback? (koobs)
Version: Latest   
Hardware: Any   
OS: Any   
See Also: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=262254
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=264324
Bug Depends on: 262361    
Bug Blocks: 262254    
Attachments:
Description Flags
a patch for update to 2.0.0
none
a patch for update to 3.0.0
none
a patch for update to 3.0.0 and update maintainer none

Description Norikatsu Shigemura 2022-02-28 17:52:09 UTC 
Created attachment 232165 [details]
a patch for update to 2.0.0

Update to 2.0.0(not 3.0.0).
I confirmed that
- aiodns 1.1.1 has some issues on latest python(3.6+),
- but aiodns 2.0.0 is OK on latest python(3.6+),
- and some applications don't work on aiodns 3.0.0.

Maybe, to support aiodns 3.0.0, some ports (i.g. pycares, ...) will be update required.  So I give up.

SEE ALSO:
https://github.com/saghul/aiodns/releases/tag/aiodns-2.0.0
https://github.com/saghul/aiodns/releases/tag/aiodns-1.2.0
Comment 1 Norikatsu Shigemura 2022-02-28 21:49:53 UTC 
Oops, sorry.
I found a problem different from 2.0.0 and 3.0.0. (on my test environments)
In /etc/resolve.conf, `nameserver 0.0.0.0` doesn't work, but `nameserver 127.0.0.1` works well.
So we can update to 3.0.0(but py-pycares must be updated).

I don't research that this issue is on aiodns and/or pycares, I'll be trying..
Comment 2 Norikatsu Shigemura 2022-03-05 15:09:54 UTC 
Created attachment 232266 [details]
a patch for update to 3.0.0
Comment 3 Norikatsu Shigemura 2022-03-05 15:11:27 UTC 
Update to 3.0.0.
- Add support for pycares 4.0.0's feature.
- Confirmed support for Python 3.10.

SEE ALSO:
- https://github.com/saghul/aiodns/releases/tag/aiodns-3.0.0
Comment 4 Norikatsu Shigemura 2022-04-10 20:14:35 UTC 
maintainer timeout.
Comment 5 p5B2EA84B3 2022-07-04 14:34:30 UTC 
Port is terrible outdated

py39-aiodns throws tons of exceptions like

Exception ignored in: <function DNSResolver.__del__ at 0x801faaca0>
Traceback (most recent call last):
  File "/usr/local/lib/python3.9/site-packages/aiodns/__init__.py", line 123, in __del__
    self._channel.destroy()
AttributeError: 'Channel' object has no attribute 'destroy'

And yes the attribute is missing.
Comment 6 p5B2EA84B3 2022-07-04 14:41:26 UTC 
(In reply to p5B2EA84B3 from comment #5)

>> AttributeError: 'Channel' object has no attribute 'destroy'

Having installed aiodns 3.0.0 with pip does not have this bug.
aiodns 3.0.0 runs like a charm on python3.9 here now.
Comment 7 Norikatsu Shigemura 2022-07-09 18:18:41 UTC 
Created attachment 235149 [details]
a patch for update to 3.0.0 and update maintainer

I'll handle this port, so please update.
Comment 8 commit-hook freebsd_committer freebsd_triage 2022-07-09 19:32:38 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=9b3c78a9dafc80cc71890cf87f24515a8a7d2569

commit 9b3c78a9dafc80cc71890cf87f24515a8a7d2569
Author:     Norikatsu Shigemura <nork@ninth-nine.com>
AuthorDate: 2022-07-09 19:19:48 +0000
Commit:     Romain Tartière <romain@FreeBSD.org>
CommitDate: 2022-07-09 19:26:20 +0000

    dns/py-aiodns: Update to 3.0.0

    Release notes:
    https://github.com/saghul/aiodns/releases/tag/aiodns-3.0.0

    PR:             262251

 dns/py-aiodns/Makefile | 9 ++++-----
 dns/py-aiodns/distinfo | 6 +++---
 2 files changed, 7 insertions(+), 8 deletions(-)
Comment 9 Romain Tartière freebsd_committer freebsd_triage 2022-07-09 19:33:26 UTC 
Committed, thanks!