Bug 262366
| Summary: | multimedia/streamlink: Update to 5.5.1 | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Naram Qashat <cyberbotx> | ||||||||||
| Component: | Individual Port(s) | Assignee: | Matthias Andree <mandree> | ||||||||||
| Status: | Closed FIXED | ||||||||||||
| Severity: | Affects Only Me | CC: | diizzy, eduardo, mandree, n_carlsson, nc, python, takefu | ||||||||||
| Priority: | --- | Keywords: | needs-qa | ||||||||||
| Version: | Latest | Flags: | takefu:
maintainer-feedback+
|
||||||||||
| Hardware: | Any | ||||||||||||
| OS: | Any | ||||||||||||
| Bug Depends on: | 262398, 262399, 264406 | ||||||||||||
| Bug Blocks: | |||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Naram Qashat
2022-03-05 17:14:32 UTC
Created attachment 232315 [details] py-streamlink-3.2.0.patch Update to 3.2.0 request bug#262398 - www/py-websocket-client: Update to 1.3.1 bug#262399 - www/py-requests: Update to 2.27.1 Currently the test fails. Created attachment 232331 [details]
Update streamlink to 3.2.0, fix test and change PORTVERSION to DISTVERSION
Looks like we are trying to update the same port.
Since I've already made this patch I'll post it and you can decide to use it if you want to.
Committed! A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=a6976a7dda52e65445ed95bd1c3cacefb9566545 commit a6976a7dda52e65445ed95bd1c3cacefb9566545 Author: Niclas Carlsson <n_carlsson@outlook.com> AuthorDate: 2022-03-08 22:05:46 +0000 Commit: Neel Chauhan <nc@FreeBSD.org> CommitDate: 2022-03-10 17:42:24 +0000 multimedia/streamlink: Update to 3.2.0 PR: 262366 Approved by: maintainer multimedia/streamlink/Makefile | 45 +++++++++++++++++------------------------ multimedia/streamlink/distinfo | 6 +++--- multimedia/streamlink/pkg-descr | 11 +++------- 3 files changed, 24 insertions(+), 38 deletions(-) (In reply to Neel Chauhan from comment #3) That's not a good idea. www/py-requests and www/py-websocket-client need to be updated first before streamlink 3.2.0 will work. Ahhh, makes sense. I reverted the patch in this commit: https://cgit.freebsd.org/ports/commit/?id=d7277abb83fad9e3a348d158f9bf9cd79853a922 And keeping this update as "open". Could someone add the "Depends on" to make it clear? Created attachment 234390 [details] py-streamlink-4.1.0.patch Update to 4.1.0 request bug#262399 - www/py-requests: Update to 2.27.1 bug#264406 - [NEW PORT] devel/py-versioningit 1.1.1 (In reply to takefu from comment #8) request bug#262398 www/py-websocket-client: Update to 1.3.1 I've asked for both the blocking bugs to be looked into, because this bug is getting quite long in the tooth, the latest version of streamlink is now at 5.1.2 so the port is very outdated. Do this update depends on https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=264406 ? I don't see a dependency on [NEW PORT] devel/py-versioningit devel/py-versioningit is a dependency for 4.0.0 and later. But I believe all requirements for 3.2.0 are now in place. Wouldn't it be better to at least get this updated to 3.2.0 until such time that needed dependencies are in place for later versions? (In reply to Niclas from comment #12) 3.2.0 was reverted in https://cgit.freebsd.org/ports/commit/?id=d7277abb83fad9e3a348d158f9bf9cd79853a922 I could revert that revert. I'm ok with updating it first to 3.2.0 and close this PR. Next a new PR should be open for 4.1.0 update and put a depend on PR from new dependency. Please tell me if everything is ok so I can revert the revert :) Cheers Friendly ping Created attachment 242089 [details] py-streamlink-5.5.1.patch Update to 5.1.2 https://streamlink.github.io/changelog.html#streamlink-5-5-1-2023-05-08 Comment on attachment 242089 [details]
py-streamlink-5.5.1.patch
renaming the file and description to match the new PORTVERSION and takefu's changelog link. will update summary again, too
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=b5f09fd13592773d34f2b656f6f88e303c786746 commit b5f09fd13592773d34f2b656f6f88e303c786746 Author: Takefu <takefu@airport.fm> AuthorDate: 2023-05-13 17:04:38 +0000 Commit: Matthias Andree <mandree@FreeBSD.org> CommitDate: 2023-05-13 17:05:18 +0000 multimedia/streamlink: maintainer update to 5.5.1 PR: 262366 multimedia/streamlink/Makefile | 52 ++++++++++++++++++----------------------- multimedia/streamlink/distinfo | 6 ++--- multimedia/streamlink/pkg-descr | 10 ++++---- 3 files changed, 31 insertions(+), 37 deletions(-) |
