Bug 262412

Summary:	DTrace failed to run when ipfw loaded
Product:	Base System	Reporter:	Li-Wen Hsu <lwhsu>
Component:	bin	Assignee:	Mark Johnston <markj>
Status:	Closed FIXED
Severity:	Affects Only Me	CC:	Trond.Endrestol, emaste, ipfw, markj, pi
Priority:	---	Flags:	koobs: mfc-stable13+ koobs: mfc-stable12-
Version:	CURRENT
Hardware:	Any
OS:	Any
See Also:	https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=262809
Bug Depends on:
Bug Blocks:	262809

Description Li-Wen Hsu freebsd_committer

2022-03-08 09:40:56 UTC

https://artifact.ci.freebsd.org/snapshot/main/23210c9f42af94dc6bcdae3996d8a3d010dd6bfe/amd64/amd64/disk-test.img.zst

FreeBSD  14.0-CURRENT FreeBSD 14.0-CURRENT #0 23210c9: Mon Mar  7 23:39:03 UTC 2022     root@FreeBSD-main-amd64-build.jail.ci.FreeBSD.org:/usr/ob
j/usr/src/amd64.amd64/sys/GENERIC amd64

root@:/ # dtrace -n 'syscall:::entry { @[execname] = count(); }' -c /bin/ls
dtrace: invalid probe specifier syscall:::entry { @[execname] = count(); }: "/usr/lib/dtrace/ipfw.d", line 1: m is not a member of struct ip_fw_args

Comment 1 Trond Endrestøl 2022-04-03 08:15:27 UTC

Everything DTrace capable must have their DTrace support disabled on systems running CURRENT and using ipfw. This poses a challenge for java/openjdk11 where there is no easy way of disabling DTrace. See https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=262809

Comment 2 commit-hook freebsd_committer

2022-04-12 21:39:00 UTC

A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=6e563a1b608438504d963c2d7c70e50d2e75af46

commit 6e563a1b608438504d963c2d7c70e50d2e75af46
Author:     Mark Johnston <markj@FreeBSD.org>
AuthorDate: 2022-04-12 19:24:40 +0000
Commit:     Mark Johnston <markj@FreeBSD.org>
CommitDate: 2022-04-12 21:29:53 +0000

    libctf: Fix recursive descent into anonymous SOU fields

    PR:             262412
    Tested by:      dhw, gallatin
    Fixes:          a6fb86917362 ("libctf: Handle CTFv3 containers")
    MFC after:      3 days
    Sponsored by:   The FreeBSD Foundation

 cddl/contrib/opensolaris/common/ctf/ctf_types.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comment 3 commit-hook freebsd_committer

2022-04-14 19:03:15 UTC

A commit in branch stable/13 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=8b01c3026b78152d9e0ca6f3758ea226f32e48b9

commit 8b01c3026b78152d9e0ca6f3758ea226f32e48b9
Author:     Mark Johnston <markj@FreeBSD.org>
AuthorDate: 2022-04-12 19:24:40 +0000
Commit:     Mark Johnston <markj@FreeBSD.org>
CommitDate: 2022-04-14 19:02:44 +0000

    libctf: Fix recursive descent into anonymous SOU fields

    PR:             262412
    Tested by:      dhw, gallatin
    Fixes:          a6fb86917362 ("libctf: Handle CTFv3 containers")
    Sponsored by:   The FreeBSD Foundation

    (cherry picked from commit 6e563a1b608438504d963c2d7c70e50d2e75af46)

 cddl/contrib/opensolaris/common/ctf/ctf_types.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comment 4 commit-hook freebsd_committer

2022-04-18 16:40:02 UTC

A commit in branch releng/13.1 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=5f649725da97c05329f8e37eb0fd4fba0f289b43

commit 5f649725da97c05329f8e37eb0fd4fba0f289b43
Author:     Mark Johnston <markj@FreeBSD.org>
AuthorDate: 2022-04-12 19:24:40 +0000
Commit:     Mark Johnston <markj@FreeBSD.org>
CommitDate: 2022-04-18 16:39:00 +0000

    libctf: Fix recursive descent into anonymous SOU fields

    Approved by:    re (gjb)
    PR:             262412
    Tested by:      dhw, gallatin
    Fixes:          a6fb86917362 ("libctf: Handle CTFv3 containers")
    Sponsored by:   The FreeBSD Foundation

    (cherry picked from commit 6e563a1b608438504d963c2d7c70e50d2e75af46)
    (cherry picked from commit 8b01c3026b78152d9e0ca6f3758ea226f32e48b9)

 cddl/contrib/opensolaris/common/ctf/ctf_types.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)