Bug 262447
| Summary: | devel/libunwind: Fix aarch64 build | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Brad Davis <brd> | ||||||
| Component: | Individual Port(s) | Assignee: | Po-Chuan Hsieh <sunpoet> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Only Me | CC: | andrew.purtell, brd, emaste, karamelichkin, marklmi26-fbsd, mikael | ||||||
| Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(sunpoet) |
||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| See Also: | https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=262257 | ||||||||
| Attachments: |
|
||||||||
Build failure here: http://ampere2.nyi.freebsd.org/data/main-arm64-default/p422f190aeba4_s23210c9f42/logs/errors/libunwind-20211201.log Pull request also opened upstream: https://github.com/libunwind/libunwind/pull/334 (In reply to Brad Davis from comment #0) Do we have the same ucontext as linux? *** Bug 262560 has been marked as a duplicate of this bug. *** Created attachment 232482 [details]
v0
Try this patch please
(In reply to Mikael Urankar from comment #4) # git -C /usr/ports apply ~/attachment.cgi\?id\=232482 /usr/home/root/attachment.cgi?id=232482:31: trailing whitespace. /usr/home/root/attachment.cgi?id=232482:32: trailing whitespace. /usr/home/root/attachment.cgi?id=232482:35: trailing whitespace. /usr/home/root/attachment.cgi?id=232482:83: trailing whitespace. @@ -59,6 +59,10 @@ extern int aarch64_local_resume (unw_addr_space_t as, /usr/home/root/attachment.cgi?id=232482:86: trailing whitespace. warning: squelched 1 whitespace error warning: 6 lines add whitespace errors. The build completed without reporting an error: [00:00:53] [01] [00:00:28] Finished devel/libunwind | libunwind-20211201: Success so previously skipped ports are starting to build. (In reply to Mark Millard from comment #5) The 42 previously skipped ports all built. Patch also works for me: git -C /usr/local/poudriere/ports/default apply attachment_232347.patch ... [00:00:22] [01] [00:00:00] Building devel/libunwind | libunwind-20211201 [00:00:50] [01] [00:00:28] Finished devel/libunwind | libunwind-20211201: Success and dependent ports are building again [00:00:50] [01] [00:00:00] Building lang/ruby27 | ruby-2.7.5_1,1 [00:06:25] [01] [00:05:35] Finished lang/ruby27 | ruby-2.7.5_1,1: Success ... (In reply to Brad Davis from comment #1) Thanks for the report. Though it is merged by upstream, I do feel that Mikael's patch (attachment 232482 [details]) seems more correct. (In reply to Mikael Urankar from comment #4) I do not have an aarch64 device but I asked another committer (kevlo@) to test it and it works. Could you please send a pull request to upstream? Thanks. (In reply to Mikael Urankar from comment #2) > Do we have the same ucontext as linux? It does not appear so. A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=b53231cc31b2d4e933ba2893c8079cc7d1f07413 commit b53231cc31b2d4e933ba2893c8079cc7d1f07413 Author: Mikael Urankar <mikael@FreeBSD.org> AuthorDate: 2022-03-23 08:29:06 +0000 Commit: Mikael Urankar <mikael@FreeBSD.org> CommitDate: 2022-03-23 08:29:06 +0000 devel/libunwind: Fix build on aarch64 PR: 262447 Approved by: portmgr (build fix blanket) .../files/patch-include_libunwind-aarch64.h (new) | 28 ++++++++++++++++++++++ .../files/patch-src_aarch64_Ginit.c (new) | 20 ++++++++++++++++ .../files/patch-src_aarch64_unwind__i.h (new) | 13 ++++++++++ 3 files changed, 61 insertions(+) Mikael: Thanks! |
Created attachment 232347 [details] patch