Bug 262558

Summary: devel/pyside2, devel/pyside2-tools: optionize webengine support
Product: Ports & Packages Reporter: Dmitry Marakasov <amdmi3>
Component: Individual Port(s)Assignee: freebsd-kde (group) <kde>
Status: Closed FIXED    
Severity: Affects Only Me CC: tcberner
Priority: --- Flags: tcberner: maintainer-feedback+
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Patch none

Description Dmitry Marakasov freebsd_committer freebsd_triage 2022-03-14 19:47:27 UTC
Created attachment 232461 [details]
Patch

WEBENGINE support is already only enabled on i386 and amd64. Make it completely optional so it's possible to avoid unneeded heavy dependency and/or bring the port in line with non-x86 archs to additionally test dependent software.
Comment 1 Tobias C. Berner freebsd_committer freebsd_triage 2022-03-18 19:15:22 UTC
Moin moin 

WEBENGINE_CMAKE_BOOL_OFF would be preferable.

mfg Tobias
Comment 2 Dmitry Marakasov freebsd_committer freebsd_triage 2022-03-22 12:47:55 UTC
> WEBENGINE_CMAKE_BOOL_OFF would be preferable.

WEBENGINE_* cannot be used here because the option only appears on i386 and amd64, so on other arches there will be no option and tied variables won't work as expected.
Comment 3 commit-hook freebsd_committer freebsd_triage 2022-03-22 19:56:46 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=05149951ce605c2781167299653b81577e5a2b64

commit 05149951ce605c2781167299653b81577e5a2b64
Author:     Dmitry Marakasov <amdmi3@FreeBSD.org>
AuthorDate: 2022-03-02 12:08:56 +0000
Commit:     Dmitry Marakasov <amdmi3@FreeBSD.org>
CommitDate: 2022-03-22 19:50:31 +0000

    devel/pyside2*: optionize webengine support

    PR:             262558
    Approved by:    tcberner

 devel/pyside2-tools/Makefile | 17 +++++++++++++----
 devel/pyside2/Makefile       | 14 +++++++++++---
 2 files changed, 24 insertions(+), 7 deletions(-)