Bug 262639

Summary:

Add support for make.conf helper variable to disable FLAVOR

Product:

Ports & Packages

Reporter:

Muhammad Moinur Rahman <bofh>

Component:

Ports Framework

Assignee:

Alex Dupre <ale>

Status:

Closed FIXED

Severity:

Affects Only Me

CC:

ale, bofh, ports-bugs, tz

Priority:

---

Flags:

bofh: maintainer-feedback? (ale)

Version:

Latest

Hardware:

Any

OS:

Any

Attachments:

Description	Flags
Disable flavor in PHP	none

Description Muhammad Moinur Rahman freebsd_committer

2022-03-18 01:47:07 UTC

Created attachment 232540 [details]
Disable flavor in PHP

Currently our php.mk is defined in such a way that when testing with poudriere if a port do not support the PHP default version it tries to build with a different php version that the port supports. Unfortunately this behavior is not too much helpful when we want to add/remove a old/new php version as it doesn't gives a clear picture of which ports fails to build with a specific PHP version. So this patch defines a variable "BUILD_ONLY_DEFAULT_FLAVOR". If this variable is defined in make.conf then poudriere will build with default flavor and in case it's not supported this will IGNORE/SKIP the port which gives a clear overview of which ports are going to create problem while adding/removing/changing default php. For example if you go here you can see how the ports are ignored/skipped while this variable is setup:
http://pdr.bofh.network/build.html?mastername=130-default-PHP80&build=2022-03-09_03h23m04s

One major issue is not all port maintainers use PKGNAMEPREFIX while flavoring their ports which actually creates the problem. Hence some ports ignores while the others tries to build them using the supported php version even though it is not the DEFAULT php.

One more thing is there are some old php modules still listed specifically dbase_DEPENDS, mssql_DEPENDS and sybase_ct_DEPENDS which are actually no longer in the tree. We should remove those.

Comment 1 commit-hook freebsd_committer

2022-04-03 21:39:40 UTC

A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=945dec8fbd3bad12712c0f80d8215935818c9292

commit 945dec8fbd3bad12712c0f80d8215935818c9292
Author:     Muhammad Moinur Rahman <bofh@FreeBSD.org>
AuthorDate: 2022-04-03 21:33:58 +0000
Commit:     Muhammad Moinur Rahman <bofh@FreeBSD.org>
CommitDate: 2022-04-03 21:33:58 +0000

    Uses/php.mk: Helper variable to disable FLAVOR

    - Currently our php.mk is defined in such a way that when testing with
      poudriere if a port do not support the PHP default version it tries to
      build with a different php version that the port supports.
      Unfortunately this behavior is not too much helpful when we want to
      add/remove a old/new php version as it doesn't gives a clear picture
      of which ports fails to build with a specific PHP version. So this
      patch defines a variable "BUILD_ONLY_DEFAULT_PHP_FLAVOR". If this
      variable is defined in make.conf then poudriere will build with default
      flavor and in case it's not supported this will IGNORE/SKIP the port which
      gives a clear overview of which ports are going to create problem
      while adding/removing/changing default php.

    - One more thing is there are some old php modules still listed
      specifically dbase_DEPENDS, mssql_DEPENDS and sybase_ct_DEPENDS which
      are actually no longer in the tree.

    PR:             262639
    Approved by:    ale (maintainer-timeout)
    Sponsored by:   Bounce Experts

 Mk/Uses/php.mk | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

Comment 2 Torsten Zuehlsdorff freebsd_committer

2022-04-04 09:30:58 UTC

Thank you! :)