Bug 262874
| Summary: | audio/libmad: Update to 0.16.0 | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Daniel Engberg <diizzy> | ||||||||
| Component: | Individual Port(s) | Assignee: | Po-Chuan Hsieh <sunpoet> | ||||||||
| Status: | Closed FIXED | ||||||||||
| Severity: | Affects Only Me | CC: | diizzy, pkubaj, vishwin | ||||||||
| Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(sunpoet) |
||||||||
| Version: | Latest | ||||||||||
| Hardware: | Any | ||||||||||
| OS: | Any | ||||||||||
| URL: | https://github.com/tenacityteam/libmad/blob/main/CHANGES | ||||||||||
| See Also: | https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=264442 | ||||||||||
| Attachments: |
|
||||||||||
pkubaj, can you have a look on PPC? There's one pending PR upstream for i386 optimization, I'll update patch once that's accepted upstream Seems ok on powerpc and powerpc64. Created attachment 232831 [details]
Patch for libmad
Use upstream commits
Created attachment 232832 [details]
Patch for libmad v3
Attach correct patch
(In reply to Piotr Kubaj from comment #3) Great, thanks! I should also add that the backported patches fixes identification of x86 for both 32-bit and 64-bit on FreeBSD A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=519c89efe3a9ddc8f3a57d1bb4940ff355086576 commit 519c89efe3a9ddc8f3a57d1bb4940ff355086576 Author: Daniel Engberg <diizzy@FreeBSD.org> AuthorDate: 2022-05-06 09:47:30 +0000 Commit: Daniel Engberg <diizzy@FreeBSD.org> CommitDate: 2022-05-06 09:59:33 +0000 audio/libmad: Update to 0.16.0 Switch to Tenacity's fork which contains patched code for all known CVEs and various build fixes. This also makes it easier to maintain as we're using an active fork. Upstream has also switched to CMake. PR: 262874 Approved by: sunpoet (maintainer timeout 4+ weeks) audio/libmad/Makefile | 30 ++--- audio/libmad/distinfo | 9 +- audio/libmad/files/mad.pc.in (gone) | 11 -- audio/libmad/files/patch-configure (gone) | 40 ------- audio/libmad/files/patch-layer12.c (gone) | 175 ------------------------------ audio/libmad/files/patch-layer3.c (gone) | 17 --- audio/libmad/pkg-plist | 10 +- 7 files changed, 23 insertions(+), 269 deletions(-) Also commenting here for more visibility: this broke at least sysutils/mtpfs and audio/audacity because those build systems now cannot detect this library. Side note, Audacity has their own fork of this library. Looking into it, thanks for reporting |
Created attachment 232766 [details] Patch for libmad Switch to Tenacity's fork which contains patched code for all known CVEs and various build fixes. This also makes it easier to maintain as we're using an active fork. Upstream has also switched to CMake. Compile tested on FreeBSD 13.0-STABLE #2 stable/13-n248607-93a95ebbf7c (amd64) (make, make check-plist) Poudriere testport OK 12.2-RELEASE (amd64) Poudriere testport OK 13.0-RELEASE (i386)