Bug 262908
| Summary: | x11-wm/xfce4-wm fix crashing, when broken client insists on nonexistent icon | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Mikhail Teterin <mi> | ||||
| Component: | Individual Port(s) | Assignee: | freebsd-xfce (Nobody) <xfce> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Some People | CC: | madpilot | ||||
| Priority: | --- | Keywords: | easy, patch-ready | ||||
| Version: | Latest | Flags: | madpilot:
maintainer-feedback+
madpilot: merge-quarterly+ |
||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| URL: | https://gitlab.xfce.org/xfce/xfwm4/-/issues/637 | ||||||
| Attachments: |
|
||||||
Thanks for reporting! I'm going to test this. For reference, this is the upstream commit with the relevant patch: https://gitlab.xfce.org/xfce/xfwm4/-/commit/a7971823de40a17dcba940fcef56d781626826d3 A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=45e9c8923b1f38f856b2df9b7385cabbff95d82c commit 45e9c8923b1f38f856b2df9b7385cabbff95d82c Author: Mikhail Teterin <mi@FreeBSD.org> AuthorDate: 2022-03-30 08:33:57 +0000 Commit: Guido Falsi <madpilot@FreeBSD.org> CommitDate: 2022-03-30 08:36:38 +0000 x11-wm/xfce4-wm: Import upsstream patch fixing crashs xfce4-wm could crash if a broken client tries to usse a nonexistent icon. Importing upstream patch that avoids the crash. PR: 262908 Obtained from: https://gitlab.xfce.org/xfce/xfwm4/-/commit/a7971823de40a17dcba940fcef56d781626826d3 MFH: 2022Q1 x11-wm/xfce4-wm/Makefile | 1 + x11-wm/xfce4-wm/files/patch-src_icons.c (new) | 46 +++++++++++++++++++++++++++ 2 files changed, 47 insertions(+) A commit in branch 2022Q1 references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=8eb564bc5a6be8cb06ea69f883397176d595933f commit 8eb564bc5a6be8cb06ea69f883397176d595933f Author: Mikhail Teterin <mi@FreeBSD.org> AuthorDate: 2022-03-30 08:33:57 +0000 Commit: Guido Falsi <madpilot@FreeBSD.org> CommitDate: 2022-03-30 08:39:04 +0000 x11-wm/xfce4-wm: Import upsstream patch fixing crashs xfce4-wm could crash if a broken client tries to usse a nonexistent icon. Importing upstream patch that avoids the crash. PR: 262908 Obtained from: https://gitlab.xfce.org/xfce/xfwm4/-/commit/a7971823de40a17dcba940fcef56d781626826d3 MFH: 2022Q1 (cherry picked from commit 45e9c8923b1f38f856b2df9b7385cabbff95d82c) x11-wm/xfce4-wm/Makefile | 1 + x11-wm/xfce4-wm/files/patch-src_icons.c (new) | 46 +++++++++++++++++++++++++++ 2 files changed, 47 insertions(+) Patch committed, and merged to quarterly. Thanks! |
Created attachment 232801 [details] Ignore nonexisting icons, instead of crashing The attached patch is an adaptation of the upstream's commit closing ticket 570 (and 637). Until a new release (4.16.2?) is made available, the port should have this patch added...