Bug 262947

Summary: www/rt50: EXTERNALAUTH option not working
Product: Ports & Packages Reporter: David Siebörger <drs-freebsd>
Component: Individual Port(s)Assignee: Mikael Urankar <mikael>
Status: Closed FIXED    
Severity: Affects Only Me Flags: bugzilla: maintainer-feedback? (mikael)
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Patch to set EXTERNALAUTH_RUN_DEPENDS none

Description David Siebörger 2022-03-30 19:28:23 UTC
Created attachment 232827 [details]
Patch to set EXTERNALAUTH_RUN_DEPENDS

When the EXTERNALAUTH option is selected, the Makefile sets EXTERNALAUTH_DEPENDS, which is of no effect.

I'm sure that ought to be EXTERNALAUTH_RUN_DEPENDS.  Building with the attached patch applied does cause the dependencies to be registered.
Comment 1 commit-hook freebsd_committer freebsd_triage 2022-03-31 09:11:34 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=f0e3e694aeb2ad5cf31c7ed8e7985d5b0e3ef719

commit f0e3e694aeb2ad5cf31c7ed8e7985d5b0e3ef719
Author:     David Siebörger <sdrs-freebsd@sieborger.nom.za>
AuthorDate: 2022-03-31 08:20:01 +0000
Commit:     Mikael Urankar <mikael@FreeBSD.org>
CommitDate: 2022-03-31 09:10:52 +0000

    www/rt50: Fix runtime dependency with EXTERNALAUTH option

    Use EXTERNALAUTH_RUN_DEPENDS to register the dependency.

    PR:             262947

 www/rt50/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Comment 2 Mikael Urankar freebsd_committer freebsd_triage 2022-03-31 09:12:05 UTC
Good catch! Thanks!
Comment 3 commit-hook freebsd_committer freebsd_triage 2022-03-31 09:15:35 UTC
A commit in branch 2022Q1 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=58a222f74702927062fbd21e0f03d64c78fa20b8

commit 58a222f74702927062fbd21e0f03d64c78fa20b8
Author:     David Siebörger <sdrs-freebsd@sieborger.nom.za>
AuthorDate: 2022-03-31 08:20:01 +0000
Commit:     Mikael Urankar <mikael@FreeBSD.org>
CommitDate: 2022-03-31 09:14:25 +0000

    www/rt50: Fix runtime dependency with EXTERNALAUTH option

    Use EXTERNALAUTH_RUN_DEPENDS to register the dependency.

    PR:             262947
    (cherry picked from commit f0e3e694aeb2ad5cf31c7ed8e7985d5b0e3ef719)

 www/rt50/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)