Bug 263041
| Summary: | emulators/open-vm-tools: fix build after 2587b74c6187 removed NDF_ONLY_PNBUF | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Dimitry Andric <dim> | ||||
| Component: | Individual Port(s) | Assignee: | Renato Botelho <garga> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Some People | Flags: | garga:
maintainer-feedback+
|
||||
| Priority: | --- | ||||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
Created attachment 232936 [details]
fix build after 2587b74c6187 removed NDF_ONLY_PNBUF
I had this change queued here together with version 12.0.0 but it's better to get it fixed earlier. It's approved, please go ahead and get it committed. Thanks! A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=c55c6dd6767ceaf37b3d69cff84d1b859e33d30e commit c55c6dd6767ceaf37b3d69cff84d1b859e33d30e Author: Dimitry Andric <dim@FreeBSD.org> AuthorDate: 2022-04-04 15:21:54 +0000 Commit: Dimitry Andric <dim@FreeBSD.org> CommitDate: 2022-04-04 17:54:55 +0000 emulators/open-vm-tools: fix build after 2587b74c6187 removed NDF_ONLY_PNBUF After base commit 2587b74c6187, which removed NDF_ONLY_PNBUF, emulators/open-vm-tools fails to build, with: --- vfsops.o --- vfsops.c:190:16: error: use of undeclared identifier 'NDF_ONLY_PNBUF'; did you mean 'NDFREE_PNBUF'? NDFREE(ndp, NDF_ONLY_PNBUF); ^~~~~~~~~~~~~~ NDFREE_PNBUF /usr/src/sys/sys/namei.h:291:6: note: 'NDFREE_PNBUF' declared here void NDFREE_PNBUF(struct nameidata *); ^ Indeed, NDFREE_PNBUF() should now be used. PR: 263041 Approved by: garga (maintainer) MFH: 2022Q2 .../files/patch-modules_freebsd_vmblock_vfsops.c | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) |
After base commit 2587b74c6187, which removed NDF_ONLY_PNBUF, emulators/open-vm-tools fails to build, with: --- vfsops.o --- vfsops.c:190:16: error: use of undeclared identifier 'NDF_ONLY_PNBUF'; did you mean 'NDFREE_PNBUF'? NDFREE(ndp, NDF_ONLY_PNBUF); ^~~~~~~~~~~~~~ NDFREE_PNBUF /usr/src/sys/sys/namei.h:291:6: note: 'NDFREE_PNBUF' declared here void NDFREE_PNBUF(struct nameidata *); ^ Indeed, NDFREE_PNBUF() should now be used.