Bug 263131

Summary: print/hplip fails to build without X11
Product: Ports & Packages Reporter: Jan Martin Mikkelsen <janm>
Component: Individual Port(s)Assignee: Tijl Coosemans <tijl>
Status: Closed FIXED    
Severity: Affects Only Me CC: ali.abdallah
Priority: --- Flags: bugzilla: maintainer-feedback? (tijl)
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Patch to handle the WITHOUT=X11 case in pkg-plist none

Description Jan Martin Mikkelsen 2022-04-08 07:57:48 UTC
Created attachment 233043 [details]
Patch to handle the WITHOUT=X11 case in pkg-plist

Building print/hplip "WITHOUT=X11" gives the result below at the end of "make package". The hplib/data/images directories are explicitly removed in the WITHOUT=X11 case, but they are not excluded in pkg-plist. Patch attached.

/bin/mkdir -p /ports-work/usr/ports/print/hplip/work/stage/var/lib/hp
/bin/rmdir /ports-work/usr/ports/print/hplip/work/stage/usr/local/share/hplip/data/images/*  /ports-work/usr/ports/print/hplip/work/stage/usr/local/share/hplip/data/images
====> Compressing man pages (compress-man)
===>  Building package for hplip-3.22.2
pkg-static: Unable to access file /ports-work/usr/ports/print/hplip/work/stage/usr/local/share/hplip/data/images/128x128/:No such file or directory
pkg-static: Unable to access file /ports-work/usr/ports/print/hplip/work/stage/usr/local/share/hplip/data/images/16x16/:No such file or directory
pkg-static: Unable to access file /ports-work/usr/ports/print/hplip/work/stage/usr/local/share/hplip/data/images/24x24/:No such file or directory
pkg-static: Unable to access file /ports-work/usr/ports/print/hplip/work/stage/usr/local/share/hplip/data/images/256x256/:No such file or directory
pkg-static: Unable to access file /ports-work/usr/ports/print/hplip/work/stage/usr/local/share/hplip/data/images/32x32/:No such file or directory
pkg-static: Unable to access file /ports-work/usr/ports/print/hplip/work/stage/usr/local/share/hplip/data/images/64x64/:No such file or directory
pkg-static: Unable to access file /ports-work/usr/ports/print/hplip/work/stage/usr/local/share/hplip/data/images/devices/:No such file or directory
pkg-static: Unable to access file /ports-work/usr/ports/print/hplip/work/stage/usr/local/share/hplip/data/images/other/:No such file or directory
*** Error code 1

Stop.
make: stopped in /usr/ports/print/hplip
Comment 1 commit-hook freebsd_committer freebsd_triage 2022-04-08 12:27:09 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=c43a15564c1d3502627f32dc46eb613724fd5061

commit c43a15564c1d3502627f32dc46eb613724fd5061
Author:     Tijl Coosemans <tijl@FreeBSD.org>
AuthorDate: 2022-04-08 12:17:52 +0000
Commit:     Tijl Coosemans <tijl@FreeBSD.org>
CommitDate: 2022-04-08 12:25:43 +0000

    print/hplip: fix pkg-plist with X11 disabled

    PR:             263131

 print/hplip/pkg-plist | 8 --------
 1 file changed, 8 deletions(-)
Comment 2 Ali Abdallah 2022-04-12 12:53:24 UTC
I would be really nice to always cherry-pick these kind of fixes to the latest supported quarterly branch! (2022Q2 in this case).
Comment 3 commit-hook freebsd_committer freebsd_triage 2022-04-13 12:13:32 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=a67a3f98ec28b607845ab6a33b2d2c5504f5b137

commit a67a3f98ec28b607845ab6a33b2d2c5504f5b137
Author:     Tijl Coosemans <tijl@FreeBSD.org>
AuthorDate: 2022-03-24 22:49:24 +0000
Commit:     Tijl Coosemans <tijl@FreeBSD.org>
CommitDate: 2022-04-13 12:11:59 +0000

    security/gnutls: update to 3.7.4

    Switch from security/ca_root_nss to base system certificate store.
    Disable obsolete TPM 1.2 support.

    PR:             257995, 260723, 263107, 263131
    Exp-run by:     antoine

 security/gnutls/Makefile                           | 30 +++++++---------
 security/gnutls/distinfo                           |  6 ++--
 .../files/patch-tests_cert-tests_pkcs12.sh (new)   | 14 ++++++++
 security/gnutls/pkg-plist                          | 40 +++++++++++++++++++---
 4 files changed, 66 insertions(+), 24 deletions(-)
Comment 4 commit-hook freebsd_committer freebsd_triage 2022-04-13 15:09:05 UTC
A commit in branch 2022Q2 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=fd9627b994f6896fc4485314188a19b8a72ac9f8

commit fd9627b994f6896fc4485314188a19b8a72ac9f8
Author:     Tijl Coosemans <tijl@FreeBSD.org>
AuthorDate: 2022-04-08 12:17:52 +0000
Commit:     Tijl Coosemans <tijl@FreeBSD.org>
CommitDate: 2022-04-13 15:07:39 +0000

    print/hplip: fix pkg-plist with X11 disabled

    PR:             263131
    (cherry picked from commit c43a15564c1d3502627f32dc46eb613724fd5061)

 print/hplip/pkg-plist | 8 --------
 1 file changed, 8 deletions(-)