Bug 263193
| Summary: | net-im/py-matrix-synapse: update to 1.56.0 | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Ashish SHUKLA <ashish> | ||||||||||
| Component: | Individual Port(s) | Assignee: | Ashish SHUKLA <ashish> | ||||||||||
| Status: | Closed FIXED | ||||||||||||
| Severity: | Affects Only Me | CC: | ports | ||||||||||
| Priority: | --- | Flags: | ports:
maintainer-feedback+
|
||||||||||
| Version: | Latest | ||||||||||||
| Hardware: | Any | ||||||||||||
| OS: | Any | ||||||||||||
| URL: | https://github.com/matrix-org/synapse/releases/tag/v1.56.0 | ||||||||||||
| Attachments: |
|
||||||||||||
Created attachment 233156 [details]
Update to 1.56.0
Sorry about the previous patch.
Patch looks good, but misses two minor dependency changes: * We now have a dependency on jinja2>=3.0.0. * We have a version cap on signedjson (<=1.1.1). The latter is only necessary for typechecking during developement and thus doesn't really matter to us (see [1]). I'd suggest removing that check from synapse's python_dependencies.py checking, like we do for the artificial cryptography check. Otherwise this will bite us if someone updates signedjson beyond 1.1.1. I've also poked upstream about this and they agree. :D I've updated your patch with these two minor changes applied. Still passes tests, builds fine and runs fine. :) Since this release includes changes that will cause synapse to refuse starting unless the configuration is adjusted and/or a complete (and time consuming) DB migration takes place, I think it would be worthwhile to also mention this in UPGRADING. :D Cheers, Sascha [1] https://github.com/matrix-org/synapse/issues/12324 Created attachment 233162 [details]
net-im/py-matrix-synapse: Update to 1.56.0 (w/ dependency adjustments)
Created attachment 233177 [details]
Update to 1.56.0 v2
It includes all the changes in the previous diffs + UPDATING entry.
Thanks!
Looks good to me, let's get this merged. :) A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=76ad2b55b71f9ba18a205d9ecdb248b78d626a0c commit 76ad2b55b71f9ba18a205d9ecdb248b78d626a0c Author: Ashish SHUKLA <ashish@FreeBSD.org> AuthorDate: 2022-04-10 11:45:30 +0000 Commit: Ashish SHUKLA <ashish@FreeBSD.org> CommitDate: 2022-04-13 13:58:07 +0000 net-im/py-matrix-synapse: Update to 1.56.0 - Mention important changes related to the upgrade to UPDATING - Update the dependency constraints Co-authored-by: Sascha Biberhofer <ports at skyforge dot at> PR: 263193 Approved by: Sascha Biberhofer <ports at skyforge dot at> (maintainer) UPDATING | 22 ++++++++++++++++++++++ net-im/py-matrix-synapse/Makefile | 4 ++-- net-im/py-matrix-synapse/distinfo | 6 +++--- .../files/patch-synapse_python__dependencies.py | 13 +++++++++++-- net-im/py-matrix-synapse/files/pkg-message.in | 17 +++++++++++++++++ 5 files changed, 55 insertions(+), 7 deletions(-) Committed, thanks! A commit in branch 2022Q2 references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=9a15ef04b4cc306bf68abfcd474eb4a1f726ccf2 commit 9a15ef04b4cc306bf68abfcd474eb4a1f726ccf2 Author: Ashish SHUKLA <ashish@FreeBSD.org> AuthorDate: 2022-04-10 11:45:30 +0000 Commit: Ashish SHUKLA <ashish@FreeBSD.org> CommitDate: 2022-06-29 04:09:54 +0000 net-im/py-matrix-synapse: Update to 1.56.0 - Mention important changes related to the upgrade to UPDATING - Update the dependency constraints Co-authored-by: Sascha Biberhofer <ports at skyforge dot at> PR: 263193 Approved by: Sascha Biberhofer <ports at skyforge dot at> (maintainer) (cherry picked from commit 76ad2b55b71f9ba18a205d9ecdb248b78d626a0c) net-im/py-matrix-synapse/Makefile | 4 ++-- net-im/py-matrix-synapse/distinfo | 6 +++--- .../files/patch-synapse_python__dependencies.py | 13 +++++++++++-- net-im/py-matrix-synapse/files/pkg-message.in | 17 +++++++++++++++++ 4 files changed, 33 insertions(+), 7 deletions(-) |
Created attachment 233119 [details] Update to 1.56.0 - Update to 1.56.0 - Note important changes since 1.55.2 in pkg-message.in Following is an excerpt from test suite: tests.replication.slave.storage.test_events.SlavedEventStoreTestCase.test_redactions tests.replication.slave.storage.test_receipts.SlavedReceiptTestCase.test_receipt tests.replication.tcp.streams.test_account_data.AccountDataStreamTestCase.test_update_function_global_account_data_limit tests.replication.tcp.streams.test_account_data.AccountDataStreamTestCase.test_update_function_room_account_data_limit tests.replication.tcp.streams.test_events.EventsStreamTestCase.test_backwards_stream_id tests.replication.tcp.streams.test_events.EventsStreamTestCase.test_update_function_event_row_limit tests.replication.tcp.streams.test_events.EventsStreamTestCase.test_update_function_huge_state_change tests.replication.tcp.streams.test_events.EventsStreamTestCase.test_update_function_state_row_limit tests.replication.tcp.streams.test_federation.FederationStreamTestCase.test_catchup tests.replication.tcp.streams.test_receipts.ReceiptsStreamTestCase.test_receipt tests.replication.tcp.streams.test_typing.TypingStreamTestCase.test_reset tests.replication.tcp.streams.test_typing.TypingStreamTestCase.test_typing ------------------------------------------------------------------------------- Ran 2278 tests in 1216.386s PASSED (skips=40, successes=2238)