Bug 263221

Summary: x11-fm/doublecmd: update to 1.0.5
Product: Ports & Packages Reporter: Beñat Gonzalez Etxepare <bbtruk>
Component: Individual Port(s)Assignee: Jose Alonso Cardenas Marquez <acm>
Status: Closed Overcome By Events    
Severity: Affects Only Me CC: acm, tcberner
Priority: --- Flags: bbtruk: merge-quarterly?
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Patch to version 1.0.5
bbtruk: maintainer-approval+
Poudriere testport none

Description Beñat Gonzalez Etxepare 2022-04-11 16:00:42 UTC 
Created attachment 233147 [details]
Patch to version 1.0.5

Changes:
- Update to version 1.0.5. Changelogs:
  https://github.com/doublecmd/doublecmd/milestone/5?closed=1

Only bug fixes, so I think it should be safe to MFH to quarterly.

Tested with Poudriere.
Comment 1 Tobias C. Berner freebsd_committer freebsd_triage 2022-04-12 16:58:51 UTC 
Moin moin 

=>> Checking for filesystem violations... done
=>> Error: Filesystem touched during build:
extra: etc/fppkg.cfg
extra: usr/local/lib/fpc/fppkg


mfg Tobias
Comment 2 Beñat Gonzalez Etxepare 2022-04-12 18:21:32 UTC 
Created attachment 233173 [details]
Poudriere testport

I can't reproduce the filesystem violations locally (see attached Poudriere log). Can you provide your log file or environment info so I can try to reproduce it?

Thanks!
Comment 3 Tobias C. Berner freebsd_committer freebsd_triage 2022-04-13 02:06:49 UTC 
(In reply to Beñat Gonzalez Etxepare from comment #2)
https://people.freebsd.org/~tcberner/logs/doublecmd-gtk2-1.0.5.log
Comment 4 Beñat Gonzalez Etxepare 2022-04-13 20:40:24 UTC 
(In reply to Tobias C. Berner from comment #3)

Thanks for the log, after some digging I have found where those files come from.

x11/doublecmd port uses lazbuild command (from editors/lazarus) to compile. And lazbuild internally calls another program, fppkg (devel/fpc-fppkg). The latter checks if configuration files exists, and if not found, it creates those files.

The way those files are created is: if the user has permissions to write to system paths (e.g. running as root), it creates those files system wide (in /etc and in $LOCALBASE/lib/fpc/fppkg). Otherwise (e.g. running as nobody), those files are created under the user's $HOME directory.

From x11/doublecmd I can't alter the way lazbuild calls fppkg (as to pass -n option, for example). So I don't know how to best solve this problem:

- Drop privileges if building as root?
- Create the config files for fppkg in the user's $HOME if they do not exist, and delete after building in that case? I don't think it adheres to best practices.
- Or should devel/fpc-fppkg be patched to install system wide config files on install and prevent creating them on first run?

Any guidance on this matter would be very much appreciated.