Bug 263352

Summary: graphics/GraphicsMagick: fails to build with graphics/libjxl installed
Product: Ports & Packages Reporter: Oleg Sidorkin <osidorkin>
Component: Individual Port(s)Assignee: Po-Chuan Hsieh <sunpoet>
Status: Closed FIXED    
Severity: Affects Only Me CC: amdmi3, jau, jbeich, sunpoet
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
URL: http://hg.code.sf.net/p/graphicsmagick/code/log/8412d044e645/coders/jxl.c
Bug Depends on:    
Bug Blocks: 265741    
Attachments:
Description Flags
disable libjxl for GraphicsMagick port osidorkin: maintainer-approval?

Description Oleg Sidorkin 2022-04-16 18:51:52 UTC
Created attachment 233257 [details]
disable libjxl for GraphicsMagick port

GraphicsMagick picks up libjxl when it is installed. However it requires libjxl API trunk and fails to build with the version from ports. GraphicsMagic commit mentions mysterious 0.7.0 version that seems to be some tag in the repository picked by debian maintainers. Attached patch disables libjxl support and supposed to be removed after libjxl update

The error is the following:


coders/jxl.c:513:19: warning: implicit declaration of function 'JxlDecoderCloseInput' is invalid in C99 [-Wimplicit-function-declaration]
                  JxlDecoderCloseInput(jxl);
                  ^
coders/jxl.c:811:3: error: use of undeclared identifier 'JxlEncoderFrameSettings'
  JxlEncoderFrameSettings
  ^
coders/jxl.c:812:6: error: use of undeclared identifier 'frame_settings'
    *frame_settings = NULL; /* Deallocated when encoder is destroyed with JxlEncoderDestroy() */
     ^
coders/jxl.c:960:3: error: use of undeclared identifier 'frame_settings'
  frame_settings = JxlEncoderFrameSettingsCreate(jxl_encoder, NULL);
  ^
coders/jxl.c:960:20: warning: implicit declaration of function 'JxlEncoderFrameSettingsCreate' is invalid in C99 [-Wimplicit-function
-declaration]
  frame_settings = JxlEncoderFrameSettingsCreate(jxl_encoder, NULL);
                   ^
coders/jxl.c:963:11: warning: implicit declaration of function 'JxlEncoderSetFrameLossless' is invalid in C99 [-Wimplicit-function-de
claration]
      if (JxlEncoderSetFrameLossless(frame_settings,JXL_TRUE) != JXL_ENC_SUCCESS)
          ^
coders/jxl.c:963:38: error: use of undeclared identifier 'frame_settings'
      if (JxlEncoderSetFrameLossless(frame_settings,JXL_TRUE) != JXL_ENC_SUCCESS)
Comment 1 Po-Chuan Hsieh freebsd_committer freebsd_triage 2022-04-16 21:12:53 UTC
Committed. Thanks!
Comment 2 commit-hook freebsd_committer freebsd_triage 2022-04-16 21:13:01 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ed1bd5c595259b8fd9bb8cfe64da36274b65e82f

commit ed1bd5c595259b8fd9bb8cfe64da36274b65e82f
Author:     Oleg Sidorkin <osidorkin@gmail.com>
AuthorDate: 2022-04-16 21:12:12 +0000
Commit:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
CommitDate: 2022-04-16 21:12:12 +0000

    graphics/GraphicsMagick: Fix build with libjxl installed

    GraphicsMagick picks up libjxl when it is installed. However it requires libjxl
    API trunk and fails to build with the version from ports. Disable libjxl
    explicitly to fix the build.

    PR:             263352

 graphics/GraphicsMagick/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 3 Po-Chuan Hsieh freebsd_committer freebsd_triage 2022-04-17 08:21:21 UTC
*** Bug 263361 has been marked as a duplicate of this bug. ***
Comment 4 Po-Chuan Hsieh freebsd_committer freebsd_triage 2022-04-24 19:45:09 UTC
*** Bug 263448 has been marked as a duplicate of this bug. ***
Comment 5 commit-hook freebsd_committer freebsd_triage 2022-04-25 17:49:25 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ce5876680bbbf05c957385e577c924a4d5117cfe

commit ce5876680bbbf05c957385e577c924a4d5117cfe
Author:     Dmitry Marakasov <amdmi3@FreeBSD.org>
AuthorDate: 2022-04-25 16:19:46 +0000
Commit:     Dmitry Marakasov <amdmi3@FreeBSD.org>
CommitDate: 2022-04-25 17:47:17 +0000

    graphics/GraphicsMagick: mark JXL option explicitly BROKEN

    PR:             263448, 263352
    Approved by:    portmgr blanket

 graphics/GraphicsMagick/Makefile | 1 +
 1 file changed, 1 insertion(+)